-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[dependabot]: Bump exoplayer_version from 1.4.1 to 1.5.1 in /packages/video_player/video_player_android/android #8414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps `exoplayer_version` from 1.4.1 to 1.5.1. Updates `androidx.media3:media3-exoplayer` from 1.4.1 to 1.5.1 - [Release notes](https://github.com/androidx/media/releases) - [Changelog](https://github.com/androidx/media/blob/release/RELEASENOTES.md) - [Commits](androidx/media@1.4.1...1.5.1) Updates `androidx.media3:media3-exoplayer-hls` from 1.4.1 to 1.5.1 - [Release notes](https://github.com/androidx/media/releases) - [Changelog](https://github.com/androidx/media/blob/release/RELEASENOTES.md) - [Commits](androidx/media@1.4.1...1.5.1) Updates `androidx.media3:media3-exoplayer-dash` from 1.4.1 to 1.5.1 - [Release notes](https://github.com/androidx/media/releases) - [Changelog](https://github.com/androidx/media/blob/release/RELEASENOTES.md) - [Commits](androidx/media@1.4.1...1.5.1) Updates `androidx.media3:media3-exoplayer-rtsp` from 1.4.1 to 1.5.1 - [Release notes](https://github.com/androidx/media/releases) - [Changelog](https://github.com/androidx/media/blob/release/RELEASENOTES.md) - [Commits](androidx/media@1.4.1...1.5.1) Updates `androidx.media3:media3-exoplayer-smoothstreaming` from 1.4.1 to 1.5.1 - [Release notes](https://github.com/androidx/media/releases) - [Changelog](https://github.com/androidx/media/blob/release/RELEASENOTES.md) - [Commits](androidx/media@1.4.1...1.5.1) Updates `androidx.media3:media3-test-utils` from 1.4.1 to 1.5.1 - [Release notes](https://github.com/androidx/media/releases) - [Changelog](https://github.com/androidx/media/blob/release/RELEASENOTES.md) - [Commits](androidx/media@1.4.1...1.5.1) --- updated-dependencies: - dependency-name: androidx.media3:media3-exoplayer dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.media3:media3-exoplayer-hls dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.media3:media3-exoplayer-dash dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.media3:media3-exoplayer-rtsp dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.media3:media3-exoplayer-smoothstreaming dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: androidx.media3:media3-test-utils dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
auto label is removed for flutter/packages/8414, due to - The status or check suite Linux_android android_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Based on the failures, this requires updating everything to build against API 35. |
@stuartmorgan does this mean that the current version of |
No, it does not. |
@camsim99 Is the Android team planning on updating this PR to work, or should we close it for now? |
…o_player_android/android/exoplayer_version-1.5.1
This comment predates the switch to |
Looks like the all-packages build will need to update to 35, which should be fine since the error message is extremely clear about what to do. Once we do that, there's a package-specific issue to resolve:
|
Ah sorry yeah I was under the impression that we weren't ready to bump the all packages app yet, but if we can now that sounds good! I can get to that within the next week, then try landing this PR unless you beat me to it. |
Usually we do it based on Flutter Fix, but here the raw error message is (unusually!) so clear that I don't think we need one. |
Lol unusual indeed! Sounds good. |
Bumps `all_packages` app to build with `compileSdk` version 35. Then, - Updates the Gradle and AGP versions to support this new Android SDK version - Refactors the legacy all_packages CI build target such that the regular `all_packages` CI build targets (master, stable) will build both the modern `all_packages` app and the legacy version with the same JDK 17 version, since the legacy version now also requires it (example successful builds: [master](https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/17102/overview), [stable](https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20stable/17086/overview)) - Updates legacy `all_packages` app `README.md` to more accurately describe how the app was transformed since its creation Prompted by #8414. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Bumps `all_packages` app to build with `compileSdk` version 35. Then, - Updates the Gradle and AGP versions to support this new Android SDK version - Refactors the legacy all_packages CI build target such that the regular `all_packages` CI build targets (master, stable) will build both the modern `all_packages` app and the legacy version with the same JDK 17 version, since the legacy version now also requires it (example successful builds: [master](https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/17102/overview), [stable](https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20stable/17086/overview)) - Updates legacy `all_packages` app `README.md` to more accurately describe how the app was transformed since its creation Prompted by flutter/packages#8414. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Bumps
exoplayer_version
from 1.4.1 to 1.5.1.Updates
androidx.media3:media3-exoplayer
from 1.4.1 to 1.5.1Release notes
Sourced from androidx.media3:media3-exoplayer's releases.
... (truncated)
Changelog
Sourced from androidx.media3:media3-exoplayer's changelog.
... (truncated)
Commits
76088cd
Bump Media3 version to 1.5.17ae9ddf
Update release notes for Media3 1.5.1 releasee4e59cd
Switch default of async crypto mode to disabled508a425
Switch play FGS exemption to use custom action instead of commands52f9761
Don't check codec's profile for MV-HEVC video.de91ebc
Add vorbis comment support for track/disc numbering fields, and genre5d9badc
Fix ReplacingCuesResolver.discardCuesBeforeTimeUs to retain active cue121b79a
Merge pull request #1943 from DolbyLaboratories:dlb/ac4-ajoc/devfa9689e
ClarifyCommandButton
javadoc aroundiconResId
andICON_UNDEFINED
f5bbb39
Merge pull request #1823 from MGaetan89:remove_outdated_sdk_checkUpdates
androidx.media3:media3-exoplayer-hls
from 1.4.1 to 1.5.1Release notes
Sourced from androidx.media3:media3-exoplayer-hls's releases.
... (truncated)
Changelog
Sourced from androidx.media3:media3-exoplayer-hls's changelog.
... (truncated)
Commits
76088cd
Bump Media3 version to 1.5.17ae9ddf
Update release notes for Media3 1.5.1 releasee4e59cd
Switch default of async crypto mode to disabled508a425
Switch play FGS exemption to use custom action instead of commands52f9761
Don't check codec's profile for MV-HEVC video.de91ebc
Add vorbis comment support for track/disc numbering fields, and genre5d9badc
Fix ReplacingCuesResolver.discardCuesBeforeTimeUs to retain active cue121b79a
Merge pull request #1943 from DolbyLaboratories:dlb/ac4-ajoc/devfa9689e
ClarifyCommandButton
javadoc aroundiconResId
andICON_UNDEFINED
f5bbb39
Merge pull request #1823 from MGaetan89:remove_outdated_sdk_checkUpdates
androidx.media3:media3-exoplayer-dash
from 1.4.1 to 1.5.1Release notes
Sourced from androidx.media3:media3-exoplayer-dash's releases.
... (truncated)
Changelog
Sourced from androidx.media3:media3-exoplayer-dash's changelog.
... (truncated)
Commits
76088cd
Bump Media3 version to 1.5.17ae9ddf
Update release notes for Media3 1.5.1 releasee4e59cd
Switch default of async crypto mode to disabled508a425
Switch play FGS exemption to use custom action instead of commands52f9761
Don't check codec's profile for MV-HEVC video.de91ebc
Add vorbis comment support for track/disc numbering fields, and genre5d9badc
Fix ReplacingCuesResolver.discardCuesBeforeTimeUs to retain active cue121b79a
Merge pull request #1943 from DolbyLaboratories:dlb/ac4-ajoc/devfa9689e
ClarifyCommandButton
javadoc aroundiconResId
andICON_UNDEFINED
f5bbb39
Merge pull request #1823 from MGaetan89:remove_outdated_sdk_checkUpdates
androidx.media3:media3-exoplayer-rtsp
from 1.4.1 to 1.5.1Release notes
Sourced from androidx.media3:media3-exoplayer-rtsp's releases.
... (truncated)
Changelog
Sourced from androidx.media3:media3-exoplayer-rtsp's changelog.
... (truncated)
Commits
76088cd
Bump Media3 version to 1.5.17ae9ddf
Update release notes for Media3 1.5.1 releasee4e59cd
Switch default of async crypto mode to disabled508a425
Switch play FGS exemption to use custom action instead of commands52f9761
Don't check codec's profile for MV-HEVC video.de91ebc
Add vorbis comment support for track/disc numbering fields, and genre5d9badc
Fix ReplacingCuesResolver.discardCuesBeforeTimeUs to retain active cue121b79a
Merge pull request #1943 from DolbyLaboratories:dlb/ac4-ajoc/devfa9689e
ClarifyCommandButton
javadoc aroundiconResId
andICON_UNDEFINED
f5bbb39
Merge pull request #1823 from MGaetan89:remove_outdated_sdk_checkUpdates
androidx.media3:media3-exoplayer-smoothstreaming
from 1.4.1 to 1.5.1Release notes
Sourced from androidx.media3:media3-exoplayer-smoothstreaming's releases.