-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Camera] Add lens type information (iOS) #8723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
dad18b9
add lens type info to camera plugin [ios-only]
lenzpaul a53858b
run pigeon generator
lenzpaul 6b8fa07
Update tests
lenzpaul e0c743a
updated versions and Changelogs
lenzpaul 78fbe47
adds dependency_overrides for federated plugin PR
lenzpaul 2248a71
Add lens type information to camera plugin tests
lenzpaul 0bbfd07
Add iOS version checks ensuring API availability for camera device types
lenzpaul 5e347d7
Apply formatting fixes
lenzpaul 989a270
created helper function for lens direction and type
lenzpaul ba8263a
Change lens type enum to only use UltraWide, Wide, and Telephoto
lenzpaul ae66e57
run pigeon gen and applied flutter_plugin_tools.dart formatting
lenzpaul ec472d7
Update CHANGELOG and Fix CI errors
lenzpaul 9540ef7
Fix formatting for CI
lenzpaul 5a3db31
Refactor camera lens direction and type handling in CameraPlugin
lenzpaul 39aac3c
Fix documentation for camera lens type descriptions in messages.dart …
lenzpaul ec7f8f2
run format script
lenzpaul 16f9fc4
Remove unnecessary pubspec changes
lenzpaul d2404a6
Remove temporary dependency overrides from pubspec.yaml files
lenzpaul 697c023
Remove Runner changes
lenzpaul 8aed9ea
Updates versions and CHANGELOGs. Runs pigeon generator
lenzpaul 119beaa
Revert implementation changes in camera_avfoundation
lenzpaul e338f6f
Revert changes in camera pkg
lenzpaul 93e2484
Updates CameraDescription tests to add toString and include lensType
lenzpaul 77fe9da
Minor changelog adjustments
stuartmorgan-g 8348878
Merge branch 'main' into camera_package_patch_2
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should get a test as well. It looks like currently we don't have a
toString
test specifically forCameraDescription
, which we should (only the indirect test in the wrong package that I'm about to change to not test this part any more).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added