Skip to content

[vector_graphics_compiler] fix a renamed method parameter lint #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2024
Merged

[vector_graphics_compiler] fix a renamed method parameter lint #8070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6d0cc2
[lint] fix a renamed method parameter
pq Nov 12, 2024
da21c9f
Update resolver.dart
pq Nov 12, 2024
ca5ae1e
Update resolver.dart
pq Nov 12, 2024
6dcc321
Merge branch 'main' into pq-patch-1
pq Nov 12, 2024
e33187d
Update resolver.dart
pq Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/vector_graphics_compiler/lib/src/svg/resolver.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,13 +287,14 @@ class ResolvingVisitor extends Visitor<Node, AffineMatrix> {
}

@override
Node visitPatternNode(PatternNode node, AffineMatrix data) {
final AttributedNode? resolvedPattern = node.resolver(node.patternId);
Node visitPatternNode(PatternNode patternNode, AffineMatrix data) {
final AttributedNode? resolvedPattern =
patternNode.resolver(patternNode.patternId);
if (resolvedPattern == null) {
return node.child.accept(this, data);
return patternNode.child.accept(this, data);
}
final Node child = node.child.accept(this, data);
final AffineMatrix childTransform = node.concatTransform(data);
final Node child = patternNode.child.accept(this, data);
final AffineMatrix childTransform = patternNode.concatTransform(data);
final Node pattern = resolvedPattern.accept(this, childTransform);

return ResolvedPatternNode(
Expand All @@ -304,7 +305,7 @@ class ResolvingVisitor extends Visitor<Node, AffineMatrix> {
width: resolvedPattern.attributes.width!,
height: resolvedPattern.attributes.height!,
transform: data,
id: node.patternId,
id: patternNode.patternId,
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/vector_graphics_compiler/lib/src/svg/visitor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ abstract class Visitor<S, V> {
S visitEmptyNode(Node node, V data);

/// Visit a [PatternNode].
S visitPatternNode(PatternNode node, V data);
S visitPatternNode(PatternNode patternNode, V data);

/// Visit a [ResolvedTextPositionNode].
S visitResolvedTextPositionNode(
Expand Down