Convert use of mini_player in the video_player_android test to AndroidVideoPlayer.
#7847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
reviewed
Oct 11, 2024
| asset: _videoAssetKey, | ||
| )))!; | ||
|
|
||
| testWidgets('can be paused', (WidgetTester tester) async { |
There was a problem hiding this comment.
Should we add back a test for pausing like this one that was removed?
There was a problem hiding this comment.
F. Yup, that was a booboo - re-added. Thanks for calling this out! Done.
There was a problem hiding this comment.
Looks like there was an additional call to await tester.pumpAndSettle(_playDuration) after pause was called in the original test. Maybe that explains the slight difference in player.getPosition(textureId) and pausedDuration causing the test failure?
There was a problem hiding this comment.
Hmm, let's try it :)
|
Thanks @camsim99! PTAL again |
camsim99
approved these changes
Oct 15, 2024
| asset: _videoAssetKey, | ||
| )))!; | ||
|
|
||
| testWidgets('can be paused', (WidgetTester tester) async { |
There was a problem hiding this comment.
Looks like there was an additional call to await tester.pumpAndSettle(_playDuration) after pause was called in the original test. Maybe that explains the slight difference in player.getPosition(textureId) and pausedDuration causing the test failure?
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2024
…test to `AndroidVideoPlayer`. (flutter/packages#7847)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 16, 2024
flutter/packages@bf751e6...a35f02d 2024-10-15 [email protected] Convert use of `mini_player` in the `video_player_android` test to `AndroidVideoPlayer`. (flutter/packages#7847) 2024-10-15 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `UniversalAdId` (flutter/packages#7833) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Lurchfresser
pushed a commit
to Lurchfresser/flutter
that referenced
this pull request
Oct 17, 2024
…r#156983) flutter/packages@bf751e6...a35f02d 2024-10-15 [email protected] Convert use of `mini_player` in the `video_player_android` test to `AndroidVideoPlayer`. (flutter/packages#7847) 2024-10-15 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `UniversalAdId` (flutter/packages#7833) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#156424.
Also improved an error message that came up as a result.