[video_player] Update Pigeon for non-nullable generics #7790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
hellohuanlin,
camsim99 and
matanlurey
as code owners
github-actions
bot
added
platform-android
platform-ios
platform-macos
p: video_player
labels
stuartmorgan-g
changed the title
matanlurey
approved these changes
Oct 4, 2024
tarrinneal
approved these changes
Oct 4, 2024
Comment on lines
-29
to
-31
| class MixWithOthersMessage { | ||
| MixWithOthersMessage(this.mixWithOthers); | ||
| bool mixWithOthers; |
There was a problem hiding this comment.
Was this just unused before?
There was a problem hiding this comment.
Yes, I somehow missed it in #6507
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 7, 2024
flutter/packages@05bf1d4...bb00d34 2024-10-07 [email protected] [google_sign_in] Update Pigeon for non-nullable generics (flutter/packages#7785) 2024-10-07 [email protected] [path_provider] Update Android Pigeon for non-nullable generics (flutter/packages#7783) 2024-10-07 [email protected] [rfw] Increase tolerance for material widget tests (flutter/packages#7148) 2024-10-05 [email protected] [various] Update Java compatibility version to 11 (flutter/packages#7795) 2024-10-04 [email protected] [video_player] Update Pigeon for non-nullable generics (flutter/packages#7790) 2024-10-04 [email protected] [go_router] Added missing implementation for the routerNeglect parameter in GoRouter (flutter/packages#7752) 2024-10-04 [email protected] [google_maps_flutter_platform_interface] Convert `BitmapDescriptor` to typesafe subclasses (flutter/packages#7699) 2024-10-04 [email protected] [google_maps_flutter_platform_interface] Convert `PatternItem` and `Cap` to typesafe structures. (flutter/packages#7703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Pigeon definition to uses non-nullable generics now that it's possible.
In practice for this plugin it's currently a no-op: the only affected collection is passed from Dart to native, on the Dart side the source was already a
Map<String, String>, and on the native side we are using languages without nullability support in generics (Java and Obj-C). However, doing this now eliminates tech debt, and will avoid problems if/when the native side switches to Kotlin/Swift.On iOS, also removes a class that was accidentally left, unused, in the Pigeon definition file after an earlier update to that file. Current versions of Pigeon would generate that class even though it's not used, so removing it from the definition avoids changes to the generated code that would otherwise have been caused by the update.
Part of flutter/flutter#155891
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).