[video_player_android] Add RTSP support #7081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
requested changes
Jul 10, 2024
There was a problem hiding this comment.
In theory this is trivial and seems OK to do.
Some feedback below. I do not have formal ownership of this plugin, and I'm not sure what our process is for deciding what support is added (versus what support is not, and we ask folks to maintain their own plugin(s)).
@reidbaker thoughts^?
In general I'm supportive, some specific comments left.
...eo_player_android/android/src/main/java/io/flutter/plugins/videoplayer/RemoteVideoAsset.java
Outdated
Show resolved
Hide resolved
...eo_player_android/android/src/main/java/io/flutter/plugins/videoplayer/RemoteVideoAsset.java
Show resolved
Hide resolved
...eo_player_android/android/src/main/java/io/flutter/plugins/videoplayer/RemoteVideoAsset.java
Outdated
Show resolved
Hide resolved
@stuartmorgan any thoughts here? |
|
We generally support formats that the underlying player supports. Unless the added dependency has a substantial code size impact, I don't see any issue here. |
|
Thank you for the feedback! I implemented the suggestions and the PR is ready for review. |
camsim99
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
This looks good to me! Deferring to @matanlurey for final review
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 30, 2024
flutter/packages@247fb5f...99e8606 2024-07-29 [email protected] [video_player_android] Add RTSP support (flutter/packages#7081) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.3.1 to 1.4.0 in /packages/video_player/video_player_android/android (flutter/packages#7241) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/camera/camera_android/android (flutter/packages#7236) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/path_provider/path_provider_android/android (flutter/packages#7244) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/packages#7234) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@247fb5f...99e8606 2024-07-29 [email protected] [video_player_android] Add RTSP support (flutter/packages#7081) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.3.1 to 1.4.0 in /packages/video_player/video_player_android/android (flutter/packages#7241) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/camera/camera_android/android (flutter/packages#7236) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/path_provider/path_provider_android/android (flutter/packages#7244) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/packages#7234) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@247fb5f...99e8606 2024-07-29 [email protected] [video_player_android] Add RTSP support (flutter/packages#7081) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 1.3.1 to 1.4.0 in /packages/video_player/video_player_android/android (flutter/packages#7241) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/camera/camera_android/android (flutter/packages#7236) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/path_provider/path_provider_android/android (flutter/packages#7244) 2024-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/packages#7234) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RTSP support to
DataSourceType.networkvideos on Android platform.I'm using this patch on my projects and it works well, but I need some feedback if the approach used is correct. If so, I will continue writing the tests.
This PR implements the Android part of this feature request: flutter/flutter#18061 .
I added a RTSP tab on the example app:
screen-20240708-224336.mp4
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.