Skip to content

Add library annotations for js interop #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Add library annotations for js interop #6216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c88f681
Add library annotations for js interop
srujzs Feb 28, 2024
3ae83ee
Publish 0.5.7
srujzs Feb 28, 2024
4270c43
Add changelog entry
srujzs Feb 28, 2024
da98615
Adjust version in changelog
stuartmorgan-g Feb 28, 2024
67a1844
Adjust version
stuartmorgan-g Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.5.6+1

* Fixes an issue where `dart:js_interop` object literal factories did not
compile with dart2js.

## 0.5.6

* Adds support for `MapConfiguration.style`.
Expand Down
6 changes: 6 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_web/lib/src/dom_window_extension.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(srujzs): Needed for https://github.com/dart-lang/sdk/issues/54801. Once
// we publish a version with a min SDK constraint that contains this fix,
// remove.
@JS()
library;

import 'dart:js_interop';

import 'package:web/web.dart' as web;
Expand Down
8 changes: 6 additions & 2 deletions packages/google_maps_flutter/google_maps_flutter_web/lib/src/map_styler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(srujzs): Needed for https://github.com/dart-lang/sdk/issues/54801. Once
// we publish a version with a min SDK constraint that contains this fix,
// remove.
@JS()
library;

import 'dart:js_interop';

/// The interop type for a Google Maps Map Styler.
///
/// See: https://developers.google.com/maps/documentation/javascript/style-reference#stylers
@JS()
@staticInterop
@anonymous
extension type MapStyler._(JSObject _) implements JSObject {
/// Create a new [MapStyler] instance.
external factory MapStyler({
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter_web
description: Web platform implementation of google_maps_flutter
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 0.5.6
version: 0.5.6+1

environment:
sdk: ^3.3.0
Expand Down