Skip to content

Conversation

@JeroenWeener
Copy link
Contributor

@JeroenWeener JeroenWeener commented Jun 5, 2023

The API changes introduced in 0.3.0 turned out to be bigger and more complicated than anticipated. This migration guide aims to help developers upgrade to 0.3.0 by giving context to the changes and treating some exemplary use cases.

The need for a migration guide was brought to my attention in flutter/flutter#127844.
A follow-up PR will update the README in the app-facing package to align with the breaking changes introduced in 0.3.0, as the current one is out-of-date.

Fixes flutter/flutter#127844

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@gmackall
Copy link
Member

gmackall commented Jun 6, 2023

Thanks for adding this guide! I'll block some time to review this this afternoon. Requesting review from @stuartmorgan as well, as you reviewed the initial migration to billing client v5 (let me know if you'd prefer I find a different secondary reviewer Stuart 🙂 ).

@gmackall gmackall requested a review from stuartmorgan-g June 6, 2023 21:10
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, but I want to hold off on approving till I can finish reading through the linked android documentations tomorrow.

@JeroenWeener JeroenWeener force-pushed the iap/127844 branch 2 times, most recently from acf6186 to d3cec0e Compare June 8, 2023 07:47
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JeroenWeener
Copy link
Contributor Author

@gmackall sorry for the inconvenience, but I updated the subscription use cases once more based on feedback in flutter/flutter#127844, as the previous examples missed a crucial detail in fetching subscription offer details.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks great! Other than converting to code excerpts, just a few minor questions.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oops, I meant that to be a Request Changes for PR status tracking.)

Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-adding my approval as this has gone through a couple of changes since my last review, but still LGTM!

I also was not aware of the existence of code-excerpts, but will make sure to recommend them moving forward

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jun 22, 2023

test-exempt: documentation

Does it make sense to call this file something more specific? (To put it another way, what do we plan to do when we add a second or third migration guide?)

@stuartmorgan-g
Copy link
Collaborator

Does it make sense to call this file something more specific? (To put it another way, what do we plan to do when we add a second or third migration guide?)

If we need more migration guides we would probably put them all in the one file, with top-level sections for each major version, since we don't know what version people will be starting from.

@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Jun 22, 2023
@stuartmorgan-g
Copy link
Collaborator

Overriding stale tree status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. needs tests p: in_app_purchase platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in_app_purchase_android v0.3.0 migration guide

4 participants