Skip to content

Conversation

@leehack
Copy link

@leehack leehack commented Dec 21, 2022

The URL doesn't match to the route when it pops twice or more due to the pattern mismatch.

When it pops from /one/two/three, it goes to /one/two/ instead of /one/two.
From the next pops, it can't match the pattern due to the / at the end of the path.
With the fix, it just makes sure to match two/ as well.

flutter/flutter#117431

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai
Copy link
Contributor

Thanks for submitting this pr, but we already have a fix waiting for review #2952

@chunhtai chunhtai closed this Dec 21, 2022
@leehack
Copy link
Author

leehack commented Dec 21, 2022

@chunhtai, I'm still wondering if we could merge this as a hotfix since it's pretty small so that we can address the issue quickly while the PR is being reviewed unless it will be merged shortly. I saw the PR is removing the function I modified, so the conflict will also be minimal. What do you think?

@chunhtai
Copy link
Contributor

I think it should be merged shortly

@leehack leehack deleted the fix-incorrect-url-after-pop-twice branch December 21, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants