Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/metrics_center/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 0.0.8
- Allow tests to override LegacyFlutterDestination GCP project id.

# 0.0.7
- Expose constants that were missing since 0.0.4+1.

Expand Down
8 changes: 7 additions & 1 deletion packages/metrics_center/lib/src/flutter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,15 @@ class FlutterDestination extends MetricDestination {
{bool isTesting = false}) async {
// Specify the project id for LegacyFlutterDestination as we may get a
// service account json from another GCP project.
//
// When we're testing, let projectId be null so we'll still use the test
// project specified by the credentials json.
//
// This is completed, but fortunately we'll be able to remove all this
// once the migration is fully done.
final LegacyFlutterDestination legacyDestination =
await LegacyFlutterDestination.makeFromCredentialsJson(json,
projectId: 'flutter-cirrus');
projectId: isTesting ? null : 'flutter-cirrus');
final SkiaPerfDestination skiaPerfDestination =
await SkiaPerfDestination.makeFromGcpCredentials(json,
isTesting: isTesting);
Expand Down