[pigeon] Null safe requires Dart 2.12 #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Dec 11, 2020
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Looks good, thanks! pPease update the pubspec.yaml and generator_tools.dart.
blasten
force-pushed
the
null_safe_pigeon
branch
from
b7b6a41 to
2ae3b9f
Compare
blasten
force-pushed
the
null_safe_pigeon
branch
3 times, most recently
from
e7b1ce6 to
cdf4454
Compare
blasten
force-pushed
the
null_safe_pigeon
branch
from
cdf4454 to
865b569
Compare
Member
|
Any idea what's going on with that test? Looks like there is a nil value for I didn't write that Podfile, it was either autogenerated by flutter or provided by e2e somehow. |
xster
reviewed
Feb 1, 2021
.cirrus.yml
Outdated
| name: local_tests | ||
| osx_instance: | ||
| image: catalina-flutter | ||
| image: high-sierra-xcode-9.4.1 |
Member
There was a problem hiding this comment.
are changes to this file intentional?
Contributor
Author
There was a problem hiding this comment.
No. This was for debugging purposes.
added 2 commits
February 1, 2021 09:42
blasten
force-pushed
the
null_safe_pigeon
branch
from
f3e423a to
d3b1794
Compare
Contributor
Author
|
@gaaclarke I am able to repro this issue locally: https://github.com/flutter/packages/runs/1809227404 - Do you know what might be causing it? |
Member
|
Yep, you have to remove xcpretty from the local_tests. I did it in an external contributors PR yet but it hasn't landed yet. |
Contributor
Author
|
🎉 finally |
austinstoker
pushed a commit
to austinstoker/packages
that referenced
this pull request
Apr 29, 2022
- closes flutter#252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required after the beta announce.