-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Upgrade AGP to 8.9.1 #10458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade AGP to 8.9.1 #10458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Android Gradle Plugin version from 8.6.0 to 8.9.1 in .ci/legacy_project/all_packages/android/settings.gradle. My review identifies a potential issue where a corresponding Gradle version update might be necessary to ensure compatibility with the new AGP version, which could otherwise lead to build failures.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please update the project change description to match.
flutter/packages@34746bb...8f72e4b 2025-11-19 [email protected] [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 [email protected] Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 [email protected] [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 [email protected] [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 [email protected] Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Upgrades AGP to 8.9.1. A few dependabot PRs are stuck because they are failing with similar error messages:
Blocked PRs:
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).