Skip to content

Conversation

@mboetger
Copy link
Contributor

Upgrades AGP to 8.9.1. A few dependabot PRs are stuck because they are failing with similar error messages:

* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > An issue was found when checking AAR metadata:

       1.  Dependency 'androidx.browser:browser:1.9.0' requires Android Gradle plugin 8.9.1 or higher.

           This build currently uses Android Gradle plugin 8.6.0.

Blocked PRs:

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android Gradle Plugin version from 8.6.0 to 8.9.1 in .ci/legacy_project/all_packages/android/settings.gradle. My review identifies a potential issue where a corresponding Gradle version update might be necessary to ensure compatibility with the new AGP version, which could otherwise lead to build failures.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update the project change description to match.

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2025
@auto-submit auto-submit bot merged commit 44be35d into flutter:main Nov 19, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2025
flutter/packages@34746bb...8f72e4b

2025-11-19 [email protected] [rfw] Update broken links in rfw's
README.md (flutter/packages#9796)
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in
/packages/image_picker/image_picker_android/android
(flutter/packages#10045)
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in
/packages/url_launcher/url_launcher_android/android
(flutter/packages#9855)
2025-11-19 [email protected] Upgrade AGP to 8.9.1
(flutter/packages#10458)
2025-11-18 [email protected] [pigeon] Update analyzer range to 8-9
(flutter/packages#10466)
2025-11-18 [email protected] [in_app_purchase] Rename Swift Pigeon
output file (flutter/packages#10465)
2025-11-18 [email protected] Roll Flutter from
cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants