[file_selector] Implement canCreateDirectories on macos and linux

[danferreira]

Updates macos and linux file_selector platforms to implement the new canCreateDirectories parameter from platform interface

Until now, only macos and linux are able to override this parameter

This is the "platform implementations" step for #9965

Part of: flutter/flutter#141339

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[gemini-code-assist]

Code Review

This pull request introduces the canCreateDirectories option across various platforms for the file_selector package. While the implementations for Linux and macOS seem complete with corresponding native changes and tests, there are some areas for improvement. Specifically, the Android and Web platforms are missing an implementation for getDirectoryPathsWithOptions, which could lead to runtime errors. On Android and Windows, the canCreateDirectories option is ignored in directory selection methods without documentation, which could be confusing. I've also noted some opportunities to reduce code duplication in the native tests for Linux and macOS to improve maintainability. My detailed feedback is in the comments below.

[gemini-code-assist]

There is a lot of repeated setup code across your test cases (e.g., initializing TestPanelController and FileSelectorPlugin). You could reduce this duplication by moving the common setup into an override func setUp() method for the ExampleTests class. This would make the tests cleaner and easier to maintain.

[stuartmorgan-g]

LGTM

@robert-ancell and @vashworth will do secondary review approvals for the two platforms.

[stuartmorgan-g]

Nit: folder

[robert-ancell]

Change looks good on Linux, thanks!

[vashworth]

macOS side LGTM

[vashworth]

Linux repo_checks test is failing due to formatting:

These files are not formatted correctly (see diff below):
   packages/file_selector/file_selector_android/example/lib/main.dart
   packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
   packages/file_selector/file_selector_linux/example/lib/home_page.dart
   packages/file_selector/file_selector_linux/example/lib/main.dart
   packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
 To fix run the repository tooling `format` command: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
 or copy-paste this command into your terminal:
 patch -p1 <<DONE
 diff --git a/packages/file_selector/file_selector_android/example/lib/main.dart b/packages/file_selector/file_selector_android/example/lib/main.dart
 index 1a2362dc1..b69b4c1e4 100644
 --- a/packages/file_selector/file_selector_android/example/lib/main.dart
 +++ b/packages/file_selector/file_selector_android/example/lib/main.dart
 @@ -40,8 +40,8 @@ class MyApp extends StatelessWidget {
        home: const HomePage(),
        routes: <String, WidgetBuilder>{
          '/open/image': (BuildContext context) => const OpenImagePage(),
 -        '/open/images':
 -            (BuildContext context) => const OpenMultipleImagesPage(),
 +        '/open/images': (BuildContext context) =>
 +            const OpenMultipleImagesPage(),
          '/open/text': (BuildContext context) => const OpenTextPage(),
        },
      );
 diff --git a/packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart b/packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
 index 0c5297313..fe7fd3d24 100644
 --- a/packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
 +++ b/packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
 @@ -22,8 +22,8 @@ class GetMultipleDirectoriesPage extends StatelessWidget {
      if (context.mounted) {
        await showDialog<void>(
          context: context,
 -        builder:
 -            (BuildContext context) => TextDisplay(directoryPaths.join('\n')),
 +        builder: (BuildContext context) =>
 +            TextDisplay(directoryPaths.join('\n')),
        );
      }
    }
 diff --git a/packages/file_selector/file_selector_linux/example/lib/home_page.dart b/packages/file_selector/file_selector_linux/example/lib/home_page.dart
 index a4e6f8288..b49884852 100644
 --- a/packages/file_selector/file_selector_linux/example/lib/home_page.dart
 +++ b/packages/file_selector/file_selector_linux/example/lib/home_page.dart
 @@ -54,8 +54,8 @@ class HomePage extends StatelessWidget {
              ElevatedButton(
                style: style,
                child: const Text('Open a get directories dialog'),
 -              onPressed:
 -                  () => Navigator.pushNamed(context, '/multi-directories'),
 +              onPressed: () =>
 +                  Navigator.pushNamed(context, '/multi-directories'),
              ),
            ],
          ),
 diff --git a/packages/file_selector/file_selector_linux/example/lib/main.dart b/packages/file_selector/file_selector_linux/example/lib/main.dart
 index f1d207839..28a342002 100644
 --- a/packages/file_selector/file_selector_linux/example/lib/main.dart
 +++ b/packages/file_selector/file_selector_linux/example/lib/main.dart
 @@ -32,13 +32,13 @@ class MyApp extends StatelessWidget {
        home: const HomePage(),
        routes: <String, WidgetBuilder>{
          '/open/image': (BuildContext context) => const OpenImagePage(),
 -        '/open/images':
 -            (BuildContext context) => const OpenMultipleImagesPage(),
 +        '/open/images': (BuildContext context) =>
 +            const OpenMultipleImagesPage(),
          '/open/text': (BuildContext context) => const OpenTextPage(),
          '/save/text': (BuildContext context) => SaveTextPage(),
          '/directory': (BuildContext context) => const GetDirectoryPage(),
 -        '/multi-directories':
 -            (BuildContext context) => const GetMultipleDirectoriesPage(),
 +        '/multi-directories': (BuildContext context) =>
 +            const GetMultipleDirectoriesPage(),
        },
      );
    }
 diff --git a/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart b/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
 index 1b11e4939..0b9fe3525 100644
 --- a/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
 +++ b/packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
 @@ -80,10 +80,9 @@ class MultipleImagesDisplay extends StatelessWidget {
            children: <Widget>[
              ...files.map(
                (XFile file) => Flexible(
 -                child:
 -                    kIsWeb
 -                        ? Image.network(file.path)
 -                        : Image.file(File(file.path)),
 +                child: kIsWeb
 +                    ? Image.network(file.path)
 +                    : Image.file(File(file.path)),
                ),
              ),
            ],
 DONE

[danferreira]

Linux repo_checks test is failing due to formatting:

These files are not formatted correctly (see diff below):
   packages/file_selector/file_selector_android/example/lib/main.dart
   packages/file_selector/file_selector_linux/example/lib/get_multiple_directories_page.dart
   packages/file_selector/file_selector_linux/example/lib/home_page.dart
   packages/file_selector/file_selector_linux/example/lib/main.dart
   packages/file_selector/file_selector_linux/example/lib/open_multiple_images_page.dart
 To fix run the repository tooling `format` command: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
 or copy-paste this command into your terminal:
 patch -p1 <<DONE
 diff --git a/packages/file_selector/file_selector_android/example/lib/main.dart b/packages/file_selector/file_selector_android/example/lib/main.dart
 ....
 DONE

Weird, for some reason dart format keeps applying those changes locally.
I fixed applying the suggested patch script instead

[stuartmorgan-g]

If you are running dart format directly instead of using the repo tooling, you probably need to run flutter pub get. Dart's formatter has behavioral changes that are gated on the min SDK version as recorded in a file in .dart_tool/, which is updated by pub get. If the file is stale, the formatter can apply the wrong version of the format.