Skip to content

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Nov 10, 2025

issue: #177110
Everytime something is pushed to the release branch, sync it back to the main branch.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@hannah-hyj hannah-hyj requested a review from chunhtai November 11, 2025 21:16
# Fetch all history for all branches
fetch-depth: 0

- name: Create Sync Pull Request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is existing github action

     - name: Create Pull Request
        uses: peter-evans/create-pull-request@v7
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          commit-message: "...."
          title: "...."
          body: "...."
          branch: release
          base: main

@hannah-hyj hannah-hyj changed the title [batch-release] Adds github action to create a PR to sync changes on the release branch back to the main branch [batch-release] Step3: Adds github action to create a PR to sync changes on the release branch back to the main branch Nov 17, 2025
on:
push:
branches:
- 'release'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I'm confused about the flow again. How can there be a single release branch that multiple packages are doing releases from while still supporting the async PR approval model? The whole point of using a branch for a release is that the branch can be a snapshot of the state that we want to release for a given package version.

@chunhtai is there a diagram or flow chart in a doc somewhere that shows the final plan for how the branches will work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I forgot about the race condition if we use single branch, where the other package may have merged and brought in new changes.

yeah.. in that case you would need separate release branch for each packages. let me revise the doc a bit and update the issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants