[ci] Adds github action for creating batch release #10298

chunhtai · 2025-10-24T18:02:28Z

To set up a batch release cron job for a package, one needs to make a copy of packages/.github/workflows/go_router_batch.yml, and change the name and cron schedule.

The cron job does the following:

trigger batch_release_pr.yaml with the input package

batch_release_pr:

check out repo
Run script/tool/lib/src/branch_for_batch_release_command.dart to create branches with all the changes
create pr request

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

chunhtai · 2025-10-27T22:46:00Z

reason for override: ci only change

.github/workflows/batch_release_pr.yml

stuartmorgan-g · 2025-10-28T14:08:12Z

packages/go_router/pending_changelogs/test_only_1.yaml

If these files are going to be created as part of the PR process, then the tooling should be updated to understand that, and the override labels shouldn't be needed on this PR. If the PR isn't landable without overrides, then the normal commit path isn't working correctly.

yes, that part of the work will be in flutter/flutter#176433.

Usually if a change to repo structure requires updates to our checks we do those two things in the same PR rather than override our own tooling, so it's not clear to me why this is being done separately. That said, since it's isolated to this package and shouldn't affect any normal PRs for now I guess it's fine.

The reason I don't do the ci check before this pr is that I would like to finalize the yaml content first, and it can't be finalized until the approach of this PR is reviewed and approved.

and I think doing it as part of this pr may be too distracting for reviewer

script/tool/lib/src/batch_command.dart

stuartmorgan-g · 2025-10-28T14:30:19Z

script/tool/lib/src/batch_command.dart

+
+    print('  Pushing to remote...');
+    final io.ProcessResult pushResult =
+        await repository.runCommand(<String>['push', 'origin', branchName, '--force']);


Here too, --force seems needlessly dangerous. I don't see why we would need to enable this command to be destructive.

stuartmorgan-g · 2025-10-28T14:33:28Z

script/tool/lib/src/batch_command.dart

+      throw FormatException('Expected "changelog" to be a list, but found ${changelogYaml.runtimeType}.');
+    }
+    final List<String> changelog = changelogYaml.nodes
+        .map((YamlNode node) => node.value as String)


What happened to allowing arbitrary markdown? How would someone make this changelog for instance?

we can use | for arbitrary markdown in yaml will need to check whether dart yaml support this properly. now I think of it maybe the changelog part of the yaml shouldn't be a list, it should just be a single element that accept arbitrary markdown.

version: major changelogs: | my *markdown* - item **one** - item two

.github/workflows/batch_release_pr.yml

script/tool/test/branch_for_batch_release_command_test.dart

script/tool/lib/src/branch_for_batch_release_command.dart

script/tool/test/branch_for_batch_release_command_test.dart

chunhtai · 2025-11-10T20:12:27Z

.github/workflows/batch_release_pr.yml

+          dart ./script/tool/lib/src/main.dart branch-for-batch-release --packages=${{ github.event.client_payload.package }} --branch=${{ env.BRANCH_NAME }} --remote=origin
+      - name: Check if branch was created
+        id: check-branch-exists
+        uses: GuillaumeFalourd/[email protected]


I am new to GA, not sure if we are allowed to use GA from marketplace, let me know if this is not allowed.

Also is there a way to test this locally?

stuartmorgan-g

LGTM with minor comments.

.github/workflows/batch_release_pr.yml

script/tool/lib/src/branch_for_batch_release_command.dart

…ackages#10298)

flutter/packages@8f72e4b...b1e2fb0 2025-11-20 [email protected] [path_provider] Convert iOS/macOS to FFI package (flutter/packages#9762) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.3.0 to 5.3.1 in /packages/espresso/android (flutter/packages#10446) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.browser:browser from 1.8.0 to 1.9.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#10115) 2025-11-19 [email protected] [ci] Adds github action for creating batch release (flutter/packages#10298) 2025-11-19 [email protected] [camera] Remove deprecated feature from Windows example (flutter/packages#10380) 2025-11-19 [email protected] Roll Flutter from cb7b7df to de4be4f (20 revisions) (flutter/packages#10468) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Oct 27, 2025

chunhtai added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 27, 2025

chunhtai requested a review from stuartmorgan-g October 27, 2025 22:50

stuartmorgan-g reviewed Oct 28, 2025

View reviewed changes

chunhtai force-pushed the issues/176425 branch 2 times, most recently from 7be1e87 to 5853905 Compare October 30, 2025 17:12

chunhtai marked this pull request as ready for review October 30, 2025 17:13

chunhtai requested a review from stuartmorgan-g October 30, 2025 17:13

chunhtai changed the title ~~[WIP] Adds github action for creating batch release~~ [ci] Adds github action for creating batch release Oct 30, 2025

stuartmorgan-g requested changes Nov 7, 2025

View reviewed changes

chunhtai force-pushed the issues/176425 branch 2 times, most recently from 48eb6ab to b201825 Compare November 10, 2025 17:41

chunhtai commented Nov 10, 2025

View reviewed changes

chunhtai requested a review from stuartmorgan-g November 10, 2025 20:15

chunhtai force-pushed the issues/176425 branch from 77ed1d2 to a7f3caf Compare November 13, 2025 19:49

stuartmorgan-g approved these changes Nov 14, 2025

View reviewed changes

chunhtai added 11 commits November 17, 2025 13:30

Adds github action for creating batch release

5a49355

adds github workflow for batch release

07088ac

push change

0510aca

update

cff52e0

update

fb2e98f

update

c9f65e6

update

ca4a1d8

update

c798da1

update

6fc0f90

update

3c14ab5

update

9bbd025

chunhtai added 12 commits November 17, 2025 13:30

add test

5ce3cff

add tests

36c6cd0

update

b3d2b92

clean up

c6f9b0a

license

c51f1a2

update

deafde9

update

7794c70

update

2356040

update

ed3bad1

update

e2b90be

format

b62585d

update

141057b

chunhtai force-pushed the issues/176425 branch from fbc05dc to 141057b Compare November 17, 2025 21:30

chunhtai added 2 commits November 17, 2025 13:59

update

0e62ea2

update

69a760d

stuartmorgan-g reviewed Nov 18, 2025

View reviewed changes

script/tool/lib/src/branch_for_batch_release_command.dart Outdated Show resolved Hide resolved

address comments

07efa9f

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2025

auto-submit bot merged commit b314944 into flutter:main Nov 19, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2025

b314944 [ci] Adds github action for creating batch release (flutter/p…

ff4b8af

…ackages#10298)

engine-flutter-autoroll mentioned this pull request Nov 20, 2025

Roll Packages from 8f72e4b9d66e to b1e2fb049013 (6 revisions) flutter/flutter#178868

Merged

[ci] Adds github action for creating batch release #10298

[ci] Adds github action for creating batch release #10298

Conversation

chunhtai commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

chunhtai commented Oct 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chunhtai commented Oct 24, 2025 •

edited

Loading