[image_picker] Fix typos in error messages for platform interface #10211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a typo in an error message for the limit parameter and improves the associated tests by making them more specific. The changes are solid. I've added a few minor suggestions to fix typos in test descriptions and to address some code duplication in the tests for better maintainability.
packages/image_picker/image_picker_platform_interface/test/media_options_test.dart
Outdated
Show resolved
Hide resolved
...ages/image_picker/image_picker_platform_interface/test/method_channel_image_picker_test.dart
Outdated
Show resolved
Hide resolved
Comment on lines
+1102
to
+1109
| final Matcher throwsLimitArgumentError = throwsA( | ||
| isA<ArgumentError>() | ||
| .having((ArgumentError error) => error.name, 'name', 'limit') | ||
| .having( | ||
| (ArgumentError error) => error.message, | ||
| 'message', | ||
| 'cannot be lower than 2', | ||
| ), | ||
| ); |
There was a problem hiding this comment.
This throwsLimitArgumentError matcher is also defined in the test for getMultiImageWithOptions around line 1841. To improve maintainability and avoid code duplication, consider defining this matcher once at the top level of the file and reusing it in both tests.
packages/image_picker/image_picker_platform_interface/test/multi_image_picker_options_test.dart
Outdated
Show resolved
Hide resolved
11 tasks
hgraceb
force-pushed
the
image_picker_interface
branch
from
ccdf957 to
b3c997f
Compare
tarrinneal
approved these changes
Oct 17, 2025
hgraceb
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2025
flutter/packages@d113bbc...9ec29b6 2025-10-22 [email protected] [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 [email protected] [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 [email protected] Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 [email protected] [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 [email protected] [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 [email protected] [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 [email protected] [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 [email protected] [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 [email protected] [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 [email protected] Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2025
flutter/packages@d113bbc...9ec29b6 2025-10-22 [email protected] [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 [email protected] [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 [email protected] Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 [email protected] [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 [email protected] [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 [email protected] [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 [email protected] [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 [email protected] [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 [email protected] [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 [email protected] [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 [email protected] Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part split from #10188.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3