Skip to content
This repository was archived by the owner on Apr 29, 2022. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 13, 2022

Fixes build issues seen in flutter/engine#32658

Will require one change when rolling into the engine to guard header includes behind this new flag instead of the more generic one.

BUILD.gn Outdated
]

if (impeller_supports_rendering) {
deps += [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be public_deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it builds.

@dnfield dnfield merged commit 011505c into flutter:main Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants