Skip to content

Re-enable one_member_abstracts lint (#3608). #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2016
Merged

Re-enable one_member_abstracts lint (#3608). #3909

merged 2 commits into from
May 13, 2016

Conversation

pq
Copy link
Contributor

@pq pq commented May 13, 2016

More context in #3608.

Leaving it to @vlidholt to decide if SyntaxHighlighter wants to be a closure (in which case we can remove the //ignore).

@pq
Copy link
Contributor Author

pq commented May 13, 2016

@Hixie PTAL.

@Hixie
Copy link
Contributor

Hixie commented May 13, 2016

LGTM

Personally I prefer a space after the // but that's neither here not there. :-)

@pq
Copy link
Contributor Author

pq commented May 13, 2016

Spaces are cheap. Will add!

@pq pq merged commit d406bb9 into flutter:master May 13, 2016
@pq pq deleted the one_member_abstracts branch August 11, 2016 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pq @Hixie