Refactoring the Android_views tests app to prepare for adding the iOS platform view tests #36200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
c: contributor-productivity
cyanglaz
added
a: platform-views
amirh
reviewed
Jul 15, 2019
| const Page(this.title, this.valueKey); | ||
|
|
||
| final String title; | ||
| final ValueKey<String> valueKey; |
Contributor
There was a problem hiding this comment.
Coming back here after reading the test code now I see, document it though.
|
|
||
| import 'package:flutter/material.dart'; | ||
|
|
||
| abstract class Page extends StatelessWidget { |
| test('recomposition', () async { | ||
| if (Platform.isAndroid) { | ||
| final SerializableFinder linkToOpenMotionEventPage = | ||
| find.byValueKey('MotionEventPage'); |
Contributor
There was a problem hiding this comment.
Sounds like this should say MotionEventsListTile
| final SerializableFinder linkToOpenMotionEventPage = | ||
| find.byValueKey('MotionEventPage'); | ||
| await driver.tap(linkToOpenMotionEventPage); | ||
| await driver.waitFor(find.byValueKey('MotionEventPageLoaded')); |
Contributor
There was a problem hiding this comment.
Call this key after the element it's used for.
|
|
||
| const String kEventsFileName = 'touchEvents'; | ||
|
|
||
| class MotionEventPage extends Page { |
| RaisedButton( | ||
| key: const ValueKey<String>('play'), | ||
| child: const Text('PLAY FILE'), | ||
| onPressed: () { |
Contributor
There was a problem hiding this comment.
Avoid reformatting the previous code if the previous formatting is good. (in multiple places)
| void diffPointerCoords(Map<String, dynamic> expected, | ||
| Map<String, dynamic> actual, int pointerIdx, StringBuffer diffBuffer) { | ||
| diffMaps(expected, actual, diffBuffer, messagePrefix: '[pointerCoord $pointerIdx] '); | ||
| diffMaps(expected, actual, diffBuffer, |
Contributor
Author
|
@amirh Updated. Ready for another review. |
amirh
approved these changes
Jul 15, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
LGTM module nits and renaming motion_event_page.dart to motion_events_page.dart
| } | ||
| for (String key in expected.keys) { | ||
| if (excludeKeys.contains(key)) | ||
| if (excludeKeys.contains(key)) |
|
|
||
| class MotionEventsPage extends Page { | ||
| const MotionEventsPage() | ||
| : super('Place circle', const ValueKey<String>('MotionEventsListTile')); |
| if (excludeKeys.contains(key)) | ||
| continue; | ||
| if (doublesApproximatelyMatch(expected[key], actual[key])) | ||
| if (doublesApproximatelyMatch(expected[key], actual[key])) |
Contributor
Author
|
Updated! |
added 2 commits
July 15, 2019 18:34
9 tasks
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
… platform view tests (flutter#36200) This PR created a main page for platform view tests in the android views testing app. The main page none contains a list of the links to the pages being tested. It puts the android view motion events tests to a sub page. The PR also added iOS related files to get ready for adding the iOS platform views tests.
This was referenced Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR created a main page for platform view tests in the android views testing app. The main page none contains a list of the links to the pages being tested. It puts the android view motion events tests to a sub page.
The PR also added iOS related files to get ready for adding the iOS platform views tests.
Following up:
Related Issues
Tests
I added the following tests:
No new tested added, modified the
recompositiontests with navigation taps.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?