Skip to content

License cpp jun20 #170948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 23, 2025
Merged

License cpp jun20 #170948

merged 15 commits into from
Jun 23, 2025

Conversation

gaaclarke
Copy link
Member

I'm down to 40 exceptions and runtime 20s.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. labels Jun 20, 2025
@gaaclarke gaaclarke requested review from matanlurey and jtmcdole June 20, 2025 23:29
@gaaclarke gaaclarke added this pull request to the merge queue Jun 23, 2025
Merged via the queue into flutter:master with commit bc30d1c Jun 23, 2025
175 checks passed
@gaaclarke gaaclarke deleted the license_cpp_jun20 branch June 23, 2025 16:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
5cbbf60
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
983f89a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 23, 2025
@engine-flutter-autoroll
Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) (#9478)
bf830ba 
flutter/flutter@0ab008a...d733bea

2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948)
2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) (flutte…
04cd745 
…r#9478)

flutter/flutter@0ab008a...d733bea

2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948)
2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@gaaclarke @mboetger
License cpp jun20 (flutter#170948)
0c458ef 
I'm down to 40 exceptions and runtime 20s.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) (flutte…
e3cac6f 
…r#9478)

flutter/flutter@0ab008a...d733bea

2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948)
2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
857d556
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
8ecac90
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
a93f8f6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
bbf498d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
bc30d1cd4 License cpp jun20 (flutter/flutter#170948)
15d583c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

Assignees
No one assigned
Labels
engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @matanlurey