adds status and alert roles #164925

chunhtai · 2025-03-10T18:35:45Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2025-03-10T18:35:50Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

mdebbar · 2025-03-11T17:30:07Z

engine/src/flutter/lib/ui/semantics.dart

@@ -462,6 +462,23 @@ enum SemanticsRole {

  /// A group of radio buttons.
  radioGroup,
+
+  /// A component to provide advisory information that is not import to


Suggested change

/// A component to provide advisory information that is not import to

/// A component to provide advisory information that is not important to

mdebbar · 2025-03-11T17:30:36Z

engine/src/flutter/lib/ui/semantics.dart

+  /// For example, a loading message for a web page.
+  status,
+
+  /// A component provide important and usually time-sensitive information.


Suggested change

/// A component provide important and usually time-sensitive information.

/// A component to provide important and usually time-sensitive information.

fixes flutter#162287 fixes flutter#162286 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions bot added engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically framework flutter/packages/flutter repository. See also f: labels. labels Mar 10, 2025

chunhtai changed the title ~~Issues/162286~~ adds status and alert roles Mar 10, 2025

chunhtai requested review from yjbanov and mdebbar March 10, 2025 22:08

chunhtai force-pushed the issues/162286 branch from 5ad4007 to 2fdfae1 Compare March 11, 2025 16:55

mdebbar approved these changes Mar 11, 2025

View reviewed changes

chunhtai added 6 commits March 12, 2025 13:11

update

f8bedd7

update

b9a3236

test

76fb0e5

update

fa20212

add more check and test

a3eb136

update

d14495c

chunhtai force-pushed the issues/162286 branch from 2fdfae1 to d14495c Compare March 12, 2025 20:11

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025

auto-submit bot added this pull request to the merge queue Mar 13, 2025

Merged via the queue into flutter:master with commit 884de61 Mar 13, 2025
171 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 884de6185518 (58 revisions) flutter/packages#8867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

ccf8068

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0a937ba4dafc (59 revisions) flutter/packages#8868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

6507925

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 627f1d200bac (60 revisions) flutter/packages#8869

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

c64aef2

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0aa0ad160ed2 (61 revisions) flutter/packages#8870

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

aa4703f

engine-flutter-autoroll mentioned this pull request Mar 16, 2025

Roll Flutter from b16430b2fd57 to d05bba1c41f6 (99 revisions) flutter/packages#8883

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

5ac6fb4

engine-flutter-autoroll mentioned this pull request Mar 16, 2025

Roll Flutter from b16430b2fd57 to d05bba1c41f6 (99 revisions) flutter/packages#8884

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

b1d4b1d

engine-flutter-autoroll mentioned this pull request Mar 17, 2025

Roll Flutter from b16430b2fd57 to 082a761570e8 (101 revisions) flutter/packages#8886

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

53b2459

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

36a301d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

ad19cb4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

69caa5f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

ee00812

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

793142d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

b1117ae

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

7104986

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

3dbb282

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

082bedb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

8fc8cd9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

fb17a7c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

1d286de

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

89b4bb1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

ca06063

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

392e4f4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

7163194

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

14ba65a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

a09fcb6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

7e5ae21

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

a65aa6d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

a33310b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

4c3767f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

884de61 adds status and alert roles (flutter/flutter#164925)

60ace3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adds status and alert roles #164925

adds status and alert roles #164925

Uh oh!

chunhtai commented Mar 10, 2025

Uh oh!

flutter-dashboard bot commented Mar 10, 2025

Uh oh!

mdebbar Mar 11, 2025

Uh oh!

mdebbar Mar 11, 2025

Uh oh!

Uh oh!

Uh oh!

	/// A component to provide advisory information that is not import to
	/// A component to provide advisory information that is not important to

	/// A component provide important and usually time-sensitive information.
	/// A component to provide important and usually time-sensitive information.

adds status and alert roles #164925

adds status and alert roles #164925

Uh oh!

Conversation

chunhtai commented Mar 10, 2025

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 10, 2025

Uh oh!

mdebbar Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

mdebbar Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!