Create helper method to dispatch object creation and disposal.

[polina-c]

Contributes to #137435.

Will test cover and convert to 'ready for review' after getting agreement about the refactoring.

[yjbanov]

The word "dispatch" (in the function names and in the dartdocs) is confusing. Is there a better word to describe it? Perhaps we are "recording" object creation, or "tracking", or "logging" it?

[polina-c]

I like 'record' more than 'dispatch' too, but:

1. 'dispatch' is more aligned with already created FlutterMemoryAllocations.instance.dispatchObjectDisposed
2. 'dispatch' is widely used accross flutter framework code, so the code reader already have to be familiar with it

But, if Flutter people prefer other name, I am open for it.

[yjbanov]

Hmm, yeah, if "dispatch" is already stuck, then I guess following the established convention makes sense. I wish I caught it earlier though. The word "dispatch" has no connection to allocation tracking.

[polina-c]

It means communicate that something was allocated or released.
The class FlutterMemoryAloocations does not record anything. But you can subscribe to it and listen to allocations.
Does it help?

[goderbauer]

Is the dart tree shaker/optimizer smart enough to remove this entire call and the $CurvedAnimation processing when the body of maybeDispatchObjectCreated is empty because kFlutterMemoryAllocationsEnabled is false? Or would we still pay a price for this line even when kFlutterMemoryAllocationsEnabled is false?

[polina-c]

yes, the class FlutterMemoryAllocations is tree shaked when kFlutterMemoryAllocationsEnabled is false

[yjbanov]

I just tried this program with dart2js in release mode:

void main() {
  print('MyApp');
  print('$MyApp');
}

class MyApp {}

And the output I got was:

MyApp
minified:vW

So I think the '$CurvedAnimation' interpolation may not work as we expect. But maybe it's not an issue if we only ever run this in debug mode?

[polina-c]

oh, interesting!
thank you for checking
we need to remove it then here and in other places

[goderbauer]

LGTM modulo the naming.

[goderbauer]

LGTM