Skip to content

Refactor devfs_web_ddc_modules_test.dart #155609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2024
Merged

Refactor devfs_web_ddc_modules_test.dart #155609

merged 3 commits into from
Oct 3, 2024

Conversation

nate-thegrate
Copy link
Contributor

@nate-thegrate nate-thegrate commented Sep 24, 2024 •
edited
Loading

This pull request adds a local function runInTestbed() to devfs_web_ddc_modules_test.dart, which wraps the testbed.run() method. Several whitespace adjustments have been made as well.


It's much easier to read after clicking "hide whitespace".


Relevant style guidelines:

  • Prefer avoiding line breaks after assignment operators.
  • If you have a newline after some opening punctuation, match it on the closing punctuation.
  • Only use => when everything, including the function declaration, fits on a single line.

@nate-thegrate nate-thegrate added the refactor Improving readability/efficiency without behavioral changes label Sep 24, 2024
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 24, 2024
@nate-thegrate nate-thegrate marked this pull request as ready for review September 24, 2024 22:10
@andrewkolos andrewkolos self-requested a review September 26, 2024 19:20
@nate-thegrate
Copy link
Contributor Author

Sweet, looks like things are passing!

andrewkolos
andrewkolos approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit auto-submit bot merged commit 5bfc3d4 into flutter:master Oct 3, 2024
120 checks passed
@nate-thegrate nate-thegrate deleted the testbed branch October 4, 2024 01:42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
db96fe5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
9c19474 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
eb592d8 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
5255a67 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
6698977 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 6, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
79f3e73 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 6, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
9fc3d4e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 8, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
9682036 
)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 8, 2024
@engine-flutter-autoroll
Manual roll Flutter from ec2e12b to 0917e9d (29 revisions) (#7816)
8625021 
Manual roll requested by [email protected]

flutter/flutter@ec2e12b...0917e9d

2024-10-05 [email protected] Roll Flutter Engine from 2068577e510b to 01de9dcf6bbf (1 revision) (flutter/flutter#156274)
2024-10-05 [email protected] Roll Flutter Engine from 6d6bc39fe8b1 to 2068577e510b (1 revision) (flutter/flutter#156267)
2024-10-05 [email protected] Roll Flutter Engine from 92b5b318190b to 6d6bc39fe8b1 (4 revisions) (flutter/flutter#156266)
2024-10-05 [email protected] Roll Flutter Engine from fd6082ab6693 to 92b5b318190b (1 revision) (flutter/flutter#156261)
2024-10-05 [email protected] Roll Flutter Engine from bc5f9fc80b06 to fd6082ab6693 (4 revisions) (flutter/flutter#156258)
2024-10-04 [email protected] Roll Flutter Engine from eece6c3ec63a to bc5f9fc80b06 (2 revisions) (flutter/flutter#156252)
2024-10-04 [email protected] Roll pub packages (flutter/flutter#156254)
2024-10-04 [email protected] Roll Flutter Engine from 9fa363bdde20 to eece6c3ec63a (1 revision) (flutter/flutter#156250)
2024-10-04 [email protected] Roll Flutter Engine from d38f5e560a98 to 9fa363bdde20 (1 revision) (flutter/flutter#156249)
2024-10-04 [email protected] remove bringup from Windows tool_integration_tests_* (flutter/flutter#156179)
2024-10-04 [email protected] Roll Flutter Engine from 205484009711 to d38f5e560a98 (4 revisions) (flutter/flutter#156239)
2024-10-04 [email protected] Normalize `ThemeData.cardTheme` (flutter/flutter#153254)
2024-10-04 [email protected] Roll Packages from 429650f to 05bf1d4 (5 revisions) (flutter/flutter#156225)
2024-10-04 [email protected] Roll Flutter Engine from e0109f0fd5b2 to 205484009711 (1 revision) (flutter/flutter#156216)
2024-10-04 [email protected] Roll pub packages (flutter/flutter#156215)
2024-10-04 [email protected] Roll Flutter Engine from c2a9fb051bd0 to e0109f0fd5b2 (1 revision) (flutter/flutter#156213)
2024-10-04 [email protected] Roll Flutter Engine from 66d397dff87a to c2a9fb051bd0 (5 revisions) (flutter/flutter#156206)
2024-10-04 [email protected] Roll Flutter Engine from 20369c5d2b93 to 66d397dff87a (5 revisions) (flutter/flutter#156188)
2024-10-03 [email protected] Roll Flutter Engine from de1762dbc5cc to 20369c5d2b93 (7 revisions) (flutter/flutter#156174)
2024-10-03 [email protected] Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609)
2024-10-03 [email protected] Allow arrow keys to navigate `MenuAnchor` independently of global shortcut definition (flutter/flutter#155728)
2024-10-03 [email protected] Inherited Theme: zero rebuilds (flutter/flutter#155699)
2024-10-03 [email protected] Roll Flutter Engine from 247bc68c578e to de1762dbc5cc (4 revisions) (flutter/flutter#156160)
2024-10-03 [email protected] Roll pub packages (flutter/flutter#156159)
2024-10-03 [email protected] pattern-matching refactor (flutter/flutter#154753)
2024-10-03 [email protected] Add autocorrect and enableSuggestions to SearchDelegate (flutter/flutter#154932)
2024-10-03 [email protected] Roll Packages from 7c97c88 to 429650f (6 revisions) (flutter/flutter#156155)
2024-10-03 [email protected] Move some tools test ownership to Ben (flutter/flutter#156123)
2024-10-03 [email protected] further shard the Windows tool_integration_tests* targets (flutter/flutter#156121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
bd9722b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
5bfc3d4 Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609
487e3c1 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App refactor Improving readability/efficiency without behavioral changes tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nate-thegrate @andrewkolos