Skip to content

Add tabs_utils.dart class #143937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add tabs_utils.dart class #143937

merged 1 commit into from
Feb 28, 2024

Conversation

TahaTesser
Copy link
Member

This a test utility class for tabs_test.dart to prepare the class for Material 3 tests updates.

More info in #139076

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 22, 2024
@TahaTesser TahaTesser marked this pull request as ready for review February 22, 2024 16:09
@TahaTesser TahaTesser requested a review from Piinks February 22, 2024 16:10
Piinks
Piinks reviewed Feb 23, 2024
View reviewed changes
packages/flutter/test/material/tabs_utils.dart

typedef TabControllerFrameBuilder = Widget Function(BuildContext context, TabController controller);

class TabStateMarker extends StatefulWidget {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're prepping this to be used across multiple test files, can you add some comments explaining what these classes can be used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, i added some comments.

packages/flutter/test/material/tabs_utils.dart
Comment on lines +127 to +108
// Assuming that the indicatorWeight is 2.0, the default.
const double indicatorWeight = 2.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different in M2 versus M3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll update the tests in the follow up PRs and verify this.

Copy link
Member Author

@TahaTesser TahaTesser Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, indicatorWeight should be 2 for tab indicator and 3 for label indicator for Material 3.

Piinks
Piinks reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to be able to reuse so much of these classes for testing! Most of the feedback is about generalizing it a bit for re-use. :)

@TahaTesser TahaTesser force-pushed the tabs_utils branch 2 times, most recently from c06a842 to 71d1a64 Compare February 26, 2024 16:29
@TahaTesser TahaTesser requested a review from Piinks February 27, 2024 15:31
Piinks
Piinks approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2024
@auto-submit auto-submit bot merged commit 5517316 into flutter:master Feb 28, 2024
@TahaTesser TahaTesser deleted the tabs_utils branch February 28, 2024 08:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
5517316 Add tabs_utils.dart class (flutter/flutter#143937)
f1b9848
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
5517316 Add tabs_utils.dart class (flutter/flutter#143937)
4a5ba56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
5517316 Add tabs_utils.dart class (flutter/flutter#143937)
9bf11b8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
5517316 Add tabs_utils.dart class (flutter/flutter#143937)
31a3ef9
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) (#6222)
6d02f03 
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@c30f998...d00bfe8

2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340)
2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338)
2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275)
2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190)
2024-02-28 [email protected] ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018)
2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316)
2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296)
2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293)
2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292)
2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290)
2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288)
2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285)
2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283)
2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050)
2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937)
2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080)
2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678)
2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229)
2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to  text field  (flutter/flutter#143601)
2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990)
2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253)
2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130)
2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001)
2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028)
2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207)
2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242)
2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185)
2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234)
2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)
2024-02-27 [email protected] Re-enable Impeller goldens blocking.  (flutter/flutter#144210)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) (flutter#6222
ffa05c1 
)

Manual roll Flutter from c30f998 to d00bfe8 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@c30f998...d00bfe8

2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340)
2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338)
2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275)
2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190)
2024-02-28 [email protected] ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018)
2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316)
2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296)
2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293)
2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292)
2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290)
2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288)
2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285)
2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283)
2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050)
2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937)
2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080)
2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678)
2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229)
2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to  text field  (flutter/flutter#143601)
2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990)
2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253)
2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130)
2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001)
2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028)
2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207)
2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242)
2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185)
2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234)
2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)
2024-02-27 [email protected] Re-enable Impeller goldens blocking.  (flutter/flutter#144210)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
5517316 Add tabs_utils.dart class (flutter/flutter#143937)
6b76fc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TahaTesser @Piinks