Add FlutterMacOS.xcframework artifact #143244

vashworth · 2024-02-09T20:31:57Z

Replace FlutterMacOS.framework cached artifact with FlutterMacOS.xcframework. Also, update usage of FlutterMacOS.framework to use FlutterMacOS.xcframework.

Part of #126016.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…work_to_cache

jmagman

LGTM!

jmagman · 2024-02-26T23:09:36Z

packages/flutter_tools/test/general.shard/artifacts_test.dart

@@ -93,12 +93,6 @@ void main() {
          .childDirectory('Flutter.framework')
          .createSync(recursive: true);

-      // TODO(jmagman): Remove ios-arm64_armv7 checks when armv7 engine artifacts are removed.


Thanks 🙂

vashworth · 2024-02-27T20:45:26Z

Reason for revert: Increased flutter_framework_uncompressed_bytes - see #144251

This reverts commit 42252cd.

Reverts #143244 Initiated by: vashworth Reason for reverting: Increased `flutter_framework_uncompressed_bytes` - see #144251 Original PR Author: vashworth Reviewed By: {jmagman} This change reverts the following previous change: Original Description: Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`. Part of #126016.

Reland #143244. It was reverted due to #144251, which is fixed by flutter/engine#51023.

Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) Manual roll requested by [email protected] flutter/flutter@c30f998...d00bfe8 2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340) 2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338) 2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275) 2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190) 2024-02-28 [email protected] ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018) 2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316) 2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296) 2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293) 2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292) 2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290) 2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288) 2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285) 2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283) 2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050) 2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937) 2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080) 2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678) 2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229) 2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to text field (flutter/flutter#143601) 2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990) 2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253) 2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130) 2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001) 2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028) 2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207) 2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242) 2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185) 2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234) 2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244) 2024-02-27 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

) Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) Manual roll requested by [email protected] flutter/flutter@c30f998...d00bfe8 2024-02-28 [email protected] Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340) 2024-02-28 [email protected] Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338) 2024-02-28 [email protected] Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275) 2024-02-28 [email protected] [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190) 2024-02-28 [email protected] ð��¡ï¸� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018) 2024-02-28 [email protected] Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316) 2024-02-28 [email protected] Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296) 2024-02-28 [email protected] Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293) 2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292) 2024-02-28 [email protected] Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290) 2024-02-28 [email protected] Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288) 2024-02-28 [email protected] Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285) 2024-02-28 [email protected] Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283) 2024-02-28 [email protected] Use const route for notAnnounced. (flutter/flutter#144050) 2024-02-28 [email protected] Add `tabs_utils.dart` class (flutter/flutter#143937) 2024-02-28 [email protected] Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080) 2024-02-27 [email protected] fix: unexpected chinese punctuation (flutter/flutter#143678) 2024-02-27 [email protected] Clean up lint ignores (flutter/flutter#144229) 2024-02-27 [email protected] Reland [a11y] Add isEnabled semantics flag to text field (flutter/flutter#143601) 2024-02-27 [email protected] Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990) 2024-02-27 [email protected] [iOS] Fix naming in platform_view example (flutter/flutter#144247) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253) 2024-02-27 [email protected] [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130) 2024-02-27 [email protected] Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001) 2024-02-27 [email protected] bind missing add icon in platform_view example (flutter/flutter#132028) 2024-02-27 [email protected] Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207) 2024-02-27 [email protected] Remove strut migration flag from `TextPainter` (flutter/flutter#144242) 2024-02-27 [email protected] Remove force Xcode debug workflow (flutter/flutter#144185) 2024-02-27 [email protected] Mark two other firebase targets as bringup: true (flutter/flutter#144234) 2024-02-27 [email protected] Add FlutterMacOS.xcframework artifact (flutter/flutter#143244) 2024-02-27 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

Add FlutterMacOS.xcframework to cache

3f9904b

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 9, 2024

Adopt usage of FlutterMacOS.xcframework

d8080cd

vashworth changed the title ~~Add FlutterMacOS.xcframework to cache~~ Add FlutterMacOS.xcframework artifact Feb 12, 2024

vashworth mentioned this pull request Feb 12, 2024

Build macOS engine as an xcframework flutter/engine#50300

Merged

8 tasks

vashworth and others added 7 commits February 22, 2024 17:08

Merge branch 'master' into add_macos_xcframework_to_cache

22927a4

Merge remote-tracking branch 'upstream/master' into add_macos_xcframe…

d143f74

…work_to_cache

fix build_macos_framework and tests

07ec7f0

Stop unzipping FlutterMacOS.framework.zip

86fb4ba

remove outdated test

7e180c8

small tweaks

f6be48a

fix test and add comment

e6b1639

vashworth marked this pull request as ready for review February 26, 2024 23:00

vashworth requested a review from jmagman February 26, 2024 23:00

jmagman approved these changes Feb 26, 2024

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024

auto-submit bot merged commit 42252cd into flutter:master Feb 27, 2024

vashworth mentioned this pull request Feb 27, 2024

Distribute macOS engine as an xcframework #126016

Open

5 tasks

gaaclarke mentioned this pull request Feb 27, 2024

flutter_framework_uncompressed_bytes increased 20 MB #144251

Closed

vashworth added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 27, 2024

auto-submit bot pushed a commit that referenced this pull request Feb 27, 2024

Revert "Add FlutterMacOS.xcframework artifact (#143244)"

e084999

This reverts commit 42252cd.

auto-submit bot mentioned this pull request Feb 27, 2024

Reverts "Add FlutterMacOS.xcframework artifact (#143244)" #144253

Merged

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 27, 2024

vashworth added a commit to vashworth/flutter that referenced this pull request Feb 27, 2024

Reland "Add FlutterMacOS.xcframework artifact (flutter#143244)"

9640e9b

vashworth mentioned this pull request Feb 27, 2024

Reland "Add FlutterMacOS.xcframework artifact (#143244)" #144275

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Feb 28, 2024

Roll Flutter from c30f998eb5db to 82ffde7ddfa2 (26 revisions) flutter/packages#6215

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024

42252cd Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)

0441973

engine-flutter-autoroll mentioned this pull request Feb 28, 2024

Roll Flutter from c30f998eb5db to d67580705242 (27 revisions) flutter/packages#6217

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024

42252cd Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)

3181292

engine-flutter-autoroll mentioned this pull request Feb 28, 2024

Roll Flutter from c30f998eb5db to 47b0ef8127d9 (28 revisions) flutter/packages#6220

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024

42252cd Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)

a285d2f

auto-submit bot pushed a commit that referenced this pull request Feb 28, 2024

Reland "Add FlutterMacOS.xcframework artifact (#143244)" (#144275)

39a1353

Reland #143244. It was reverted due to #144251, which is fixed by flutter/engine#51023.

engine-flutter-autoroll mentioned this pull request Feb 28, 2024

Manual roll Flutter from c30f998eb5db to d00bfe820eef (32 revisions) flutter/packages#6222

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024

42252cd Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)

a4f853f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

42252cd Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)

13dffe7

jmagman mentioned this pull request May 16, 2024

MacOS: Codemagic - The installer package includes files that are only readable by the root user (3.22.0) #148354

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add FlutterMacOS.xcframework artifact #143244

Add FlutterMacOS.xcframework artifact #143244

Uh oh!

vashworth commented Feb 9, 2024 •

edited

Loading

Uh oh!

jmagman left a comment

Uh oh!

jmagman Feb 26, 2024

Uh oh!

vashworth commented Feb 27, 2024

Uh oh!

Uh oh!

Add FlutterMacOS.xcframework artifact #143244

Add FlutterMacOS.xcframework artifact #143244

Uh oh!

Conversation

vashworth commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman Feb 26, 2024

Choose a reason for hiding this comment

Uh oh!

vashworth commented Feb 27, 2024

Uh oh!

Uh oh!

vashworth commented Feb 9, 2024 •

edited

Loading