Skip to content

Test cover cupertino for memory leaks and fix Opacity Layer not disposed. [prod-leak-fix] #136576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 6 commits into from
Oct 15, 2023
Merged

Test cover cupertino for memory leaks and fix Opacity Layer not disposed. [prod-leak-fix] #136576

polina-c merged 6 commits into from
Oct 15, 2023

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 14, 2023

Description

As a part of Issue: #134 this PR includes coverage for test/cupertino/ by changing testWidgets to testWidgetsWithLeakTracking .

Tests

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository labels Oct 14, 2023
@droidbg droidbg marked this pull request as ready for review October 14, 2023 11:35
@droidbg
Copy link
Contributor Author

droidbg commented Oct 15, 2023

@polina-c could you pls review this PR?

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 15, 2023
@polina-c polina-c merged commit 77c19f5 into flutter:master Oct 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 16, 2023
@engine-flutter-autoroll
77c19f5 Test cover cupertino for memory leaks and fix Opacity Layer n…
8da1d47 
…ot disposed. (flutter/flutter#136576)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 16, 2023
@engine-flutter-autoroll
Roll Flutter from b00216b to afc3916 (12 revisions) (#5156)
892d80f 
flutter/flutter@b00216b...afc3916

2023-10-16 [email protected] Roll Flutter Engine from cfff75967b06 to 505c720fd10f (1 revision) (flutter/flutter#136636)
2023-10-16 [email protected] Roll Flutter Engine from bd038d688ed3 to cfff75967b06 (1 revision) (flutter/flutter#136635)
2023-10-16 [email protected] Roll Flutter Engine from 15dee700867b to bd038d688ed3 (1 revision) (flutter/flutter#136626)
2023-10-16 [email protected] Roll Flutter Engine from 41b3b4f90cd9 to 15dee700867b (1 revision) (flutter/flutter#136625)
2023-10-16 [email protected] Fix `NavigationRail`'s indicator inkwell doesn't support transparent color. (flutter/flutter#136359)
2023-10-16 [email protected] Roll Flutter Engine from 12122eac2820 to 41b3b4f90cd9 (1 revision) (flutter/flutter#136623)
2023-10-16 [email protected] Roll Flutter Engine from 539ad5b232a6 to 12122eac2820 (2 revisions) (flutter/flutter#136619)
2023-10-16 [email protected] Roll Flutter Engine from 452e75f2a6b6 to 539ad5b232a6 (1 revision) (flutter/flutter#136617)
2023-10-16 [email protected] Roll Flutter Engine from 72598229bec9 to 452e75f2a6b6 (1 revision) (flutter/flutter#136614)
2023-10-15 [email protected] Roll Flutter Engine from f8eb68b115f1 to 72598229bec9 (2 revisions) (flutter/flutter#136611)
2023-10-15 [email protected] Test cover cupertino for memory leaks and fix Opacity Layer not disposed. (flutter/flutter#136576)
2023-10-15 [email protected] Test cover cupertino for memory leaks tracking -2  (flutter/flutter#136577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@droidbg droidbg deleted the cupertino-leak-tracking branch November 13, 2023 01:43
@polina-c polina-c changed the title Test cover cupertino for memory leaks and fix Opacity Layer not disposed. Test cover cupertino for memory leaks and fix Opacity Layer not disposed. [prod-leak-fix] Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@droidbg @polina-c