Skip to content

Cover more test/widgets tests with leak tracking #6 #134884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2023
Merged

Cover more test/widgets tests with leak tracking #6 #134884

merged 2 commits into from
Sep 18, 2023

Conversation

ksokolovskyi
Copy link
Contributor

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates notification_test.dart to use testWidgetsWithLeakTracking;
  • Updates obscured_animated_image_test.dart to use testWidgetsWithLeakTracking;
  • Updates opacity_repaint_test.dart to use testWidgetsWithLeakTracking;
  • Updates opacity_test.dart to use testWidgetsWithLeakTracking;
  • Updates overflow_bar_test.dart to use testWidgetsWithLeakTracking;
  • Updates overflow_box_test.dart to use testWidgetsWithLeakTracking;
  • Updates overlay_portal_test.dart to use testWidgetsWithLeakTracking;
  • Updates overscroll_indicator_test.dart to use testWidgetsWithLeakTracking;
  • Updates overscroll_stretch_indicator_test.dart to use testWidgetsWithLeakTracking;
  • Updates page_forward_transitions_test.dart to use testWidgetsWithLeakTracking;
  • Updates page_route_builder_test.dart to use testWidgetsWithLeakTracking;
  • Updates page_storage_test.dart to use testWidgetsWithLeakTracking;
  • Updates page_transitions_test.dart to use testWidgetsWithLeakTracking;
  • Updates page_view_test.dart to use testWidgetsWithLeakTracking;
  • Updates pageable_list_test.dart to use testWidgetsWithLeakTracking;
  • Updates parent_data_test.dart to use testWidgetsWithLeakTracking;
  • Updates performance_overlay_test.dart to use testWidgetsWithLeakTracking;
  • Updates physical_model_test.dart to use testWidgetsWithLeakTracking;
  • Updates placeholder_test.dart to use testWidgetsWithLeakTracking;
  • Updates platform_menu_bar_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Sep 16, 2023
@ksokolovskyi
Copy link
Contributor Author

cc @polina-c

@polina-c polina-c mentioned this pull request Sep 18, 2023
Closed
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 18, 2023

auto label is removed for flutter/flutter/134884, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@polina-c polina-c merged commit 2396a41 into flutter:master Sep 18, 2023
@ksokolovskyi
Copy link
Contributor Author

@polina-c thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
2396a41 Cover more test/widgets tests with leak tracking flutter#6 (f…
d3b8c89 
…lutter/flutter#134884)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
Roll Flutter from b7d0e8c to 8936504 (15 revisions) (#4947)
59febcd 
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Cover more test/widgets tests with leak tracking flutter#6 (flutter#1…
cbd7e81 
…34884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
2396a41 Cover more test/widgets tests with leak tracking flutter#6 (f…
b368009 
…lutter/flutter#134884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksokolovskyi @polina-c