Skip to content

[CP] Constrain _RenderScaledInlineWidget child size in computeDryLayout #131765 #132096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2023
Merged

[CP] Constrain _RenderScaledInlineWidget child size in computeDryLayout #131765 #132096

merged 2 commits into from
Aug 8, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

CP request: #132095

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Aug 7, 2023
@LongCatIsLooong LongCatIsLooong mentioned this pull request Aug 7, 2023
Closed
@CaseyHillers CaseyHillers requested a review from chunhtai August 7, 2023 23:22
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023
@auto-submit auto-submit bot merged commit 95b3a3e into flutter:flutter-3.13-candidate.0 Aug 8, 2023
@LongCatIsLooong LongCatIsLooong deleted the cp-131765 branch August 8, 2023 18:05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
95b3a3ed9 [CP] Constrain _RenderScaledInlineWidget child size in comp…
2d97604 
…uteDryLayout #131765 (flutter/flutter#132096)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
95b3a3ed9 [CP] Constrain _RenderScaledInlineWidget child size in comp…
acb4528 
…uteDryLayout #131765 (flutter/flutter#132096)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
95b3a3ed9 [CP] Constrain _RenderScaledInlineWidget child size in comp…
4796a79 
…uteDryLayout #131765 (flutter/flutter#132096)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
95b3a3ed9 [CP] Constrain _RenderScaledInlineWidget child size in comp…
2c70951 
…uteDryLayout #131765 (flutter/flutter#132096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai Awaiting requested review from chunhtai

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @CaseyHillers @tgucio