unexpected binary file in flutter 3.24 engine build: "But it is not in the entitlements configuration files you provided"

[christopherfujino]

From https://logs.chromium.org/logs/dart-internal/buildbucket/cr-buildbucket/8739500917885725377/+/u/Global_generators/Codesign__Volumes_Work_s_w_ir_cache_builder_src_out_release_unsigned_artifacts.zip/codesign_Apple_engine_binaries/stdout

[SEVERE] codesign: the binary file Flutter is causing an issue. 
This file is located at extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter in the flutter engine artifact.
[SEVERE] codesign: The system has detected a binary file at extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter. But it is not in the entitlements configuration files you provided. If this is a new engine artifact, please add it to one of the entitlements.txt files.
Unhandled exception:
Exception: Codesign test failed.

We compared binary files in engine artifacts with those listed in
entitlement.txt and withoutEntitlements.txt, and the binary files do not match.
*entitlements.txt is the configuration file encoded in engine artifact zip,
built by BUILD.gn and Ninja, to detail the list of entitlement files.
Either an expected file was not found in *entitlements.txt, or an unexpected
file was found in entitlements.txt.

This usually happens during an engine roll.
If this is a valid change, then BUILD.gn needs to be changed.
Binaries that will run on a macOS host require entitlements, and
binaries that run on an iOS device must NOT have entitlements.
For example, if this is a new binary that runs on macOS host, add it
to [entitlements.txt] file inside the zip artifact produced by BUILD.gn.
If this is a new binary that needs to be run on iOS device, add it
to [withoutEntitlements.txt].
If there are obsolete binaries in entitlements configuration files, please delete or
update these file paths accordingly.

[christopherfujino]

I suspect this CP: https://github.com/flutter/engine/pull/54513/files

[christopherfujino]

cc @cbracken

If we really did intend to add this file, then I think we need to make sure the entitlements file knows about it. I forget how to do that.

[christopherfujino]

I'm guessing we want to add it here? https://github.com/flutter/engine/blob/flutter-3.24-candidate.0/sky/tools/create_full_ios_framework.py#L199-L204

[christopherfujino]

Ahh, looks like we already CP'd this to flutter-3.24-candidate.1 branch: https://github.com/flutter/engine/pull/54573/files

[cbracken]

Yep the candidate release build built successfully with that patch -- see notes on the patch you mentioned as well as in this patch to main: flutter/engine#54576

I was thinking there'd be an additional conditional we needed to avoid adding these in debug/profile builds (we don't bundle dSYMs for them since they have debug info already), which is in the patch to main linked in this comment, but actually it's unnecessary since we're not signing those.

Copy-pasted links to successful builds for the above-mentioned 3.24-candidate.1 branch so current/future archaeologists don't need to go digging further:

Here's the patch sent to the branch:
flutter/engine#54573

The build associated with that patch correctly completed code signing in this build:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20engine_release_builder/688/overview

And more specifically, this sub-build:
https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/13650/overview

And even more specifically, this build step:
https://logs.chromium.org/logs/dart-internal/buildbucket/cr-buildbucket/8739493904842446705/+/u/Global_generators/Codesign__Volumes_Work_s_w_ir_cache_builder_src_out_release_unsigned_artifacts.zip/codesign_Apple_engine_binaries/stdout

[cbracken]

Fixes landed both on candidate branch and main.

[christopherfujino]

Fixes landed both on candidate branch and main.

Confusingly, there's still one more branch I think we need to CP this to: https://github.com/flutter/engine/commits/flutter-3.24-candidate.0/

I will try to patch in the hotfix to chingjun's branch to this one...