This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use all font managers to discover fonts for strut. #7734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Feb 7, 2019
chinmaygarde
approved these changes
Feb 7, 2019
|
Waiting on framework (flutter/flutter#27612) and golden changes to land. |
This was referenced Feb 7, 2019
GaryQian
added a commit
to GaryQian/engine
that referenced
this pull request
Feb 12, 2019
)" This reverts commit c4a5555.
GaryQian
added a commit
that referenced
this pull request
Feb 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2019
flutter/engine@d48de7a...3757390 git log d48de7a..3757390 --no-merges --oneline 3757390 Roll src/third_party/dart ecd7a88606..0a7dcf17eb (4 commits) 61d3080 Add FFI to libraries.yaml. (flutter/engine#7811) f5259b8 Roll src/third_party/skia b6f53783337e..186669c4128b (8 commits) (flutter/engine#7816) 816921b Use newer Skia API for PathMeasure (flutter/engine#7809) da56ff9 Roll src/third_party/skia 94a5328e0e4b..b6f53783337e (8 commits) (flutter/engine#7812) 04fbc25 Roll src/third_party/skia 66f09a72995a..94a5328e0e4b (1 commits) (flutter/engine#7810) 347d690 Add support for new Scenic clip planes. (flutter/engine#7804) 309b90c Roll src/third_party/skia 14d64dd4c47c..66f09a72995a (8 commits) (flutter/engine#7805) 1dead52 Roll src/third_party/skia 0b6ae6386d34..14d64dd4c47c (10 commits) (flutter/engine#7802) 74d94e5 Revert "Use all font managers to discover fonts for strut. (#7734)" (flutter/engine#7801) 769016c Roll src/third_party/skia 63d477cd99b0..0b6ae6386d34 (9 commits) (flutter/engine#7798) f7eb3cb Roll src/third_party/skia 217acf58d0d8..63d477cd99b0 (1 commits) (flutter/engine#7797) c4a5555 Use all font managers to discover fonts for strut. (flutter/engine#7734) 17b7d1e Roll src/third_party/dart 754e5f404c..ecd7a88606 (8 commits) b4ed8cf Roll src/third_party/skia 233fc0b03c02..217acf58d0d8 (1 commits) (flutter/engine#7795) 27ab9f7 Roll src/third_party/skia 454e5fb7457d..233fc0b03c02 (4 commits) (flutter/engine#7794) c58f5fe Roll src/third_party/dart fdfe40ea95..754e5f404c (13 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much better and more correct way to obtain direct font metrics using the existing API.
This rolls back FontCollection::GetMinikinFontForFamilies as it is no longer necessary or correct.
Will require a manual engine roll as this changes tests that were written against the old version.