Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

matanlurey
Copy link
Contributor

The logical "part 2" of the work started in #55540.

Test output does not change, the tests just no longer rely on the global fixtures.dart data.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2024
@auto-submit auto-submit bot merged commit 1594254 into flutter:main Oct 2, 2024
30 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2024
…156107)

flutter/engine@f206812...3bdc1c0

2024-10-02 [email protected] Use localized config data for `et test` tests. (flutter/engine#55573)
2024-10-02 [email protected] Use localized config data for `et query` tests. (flutter/engine#55572)
2024-10-02 [email protected] Roll Skia from 41dc26036445 to ce27189cef4b (1 revision) (flutter/engine#55587)
2024-10-02 [email protected] Roll Skia from d063b5e450db to 41dc26036445 (2 revisions) (flutter/engine#55586)
2024-10-02 [email protected] iOS: Migrate accessibility_bridge to ARC (flutter/engine#55570)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Dec 18, 2024
The logical "part 2" of the work started in flutter/engine#55540.

Test output does not change, the tests just no longer rely on the global `fixtures.dart` data.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants