Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add copyright notices to java test files #55155

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add copyright notices to java test files #55155

merged 2 commits into from
Sep 13, 2024

Conversation

reidbaker
Copy link
Contributor

Fixes flutter/flutter/issues/155118

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from zanderso September 12, 2024 19:34
@reidbaker reidbaker mentioned this pull request Sep 12, 2024
Merged
8 tasks
@reidbaker reidbaker requested a review from a team September 12, 2024 19:36
yaakovschectman
yaakovschectman approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you need to add to the ci/licenses files?

@reidbaker
Copy link
Contributor Author

LGTM. Do you need to add to the ci/licenses files?

Can you link to an example of what you are talking about?

@yaakovschectman
Copy link
Contributor

Previously, when I have added files that needed accompanying license headers, lines needed to be added/altered in https://github.com/flutter/engine/blob/main/ci/licenses_golden/licenses_flutter

@reidbaker
Copy link
Contributor Author

flutter/flutter/issues/155118

Nothing was flagging these files before and checking I found no examples of test/io/flutter/embedding.
The answer is probably "literally no but something should be checking these files".

I have a open question out for what should have been checking all these files.

@zanderso
Copy link
Member

The license checker is probably skipping tests since they are not part of the shipped engine, however when we get around to improving the license checker it should check that all source files outside of third_party have the engine header.

zanderso
zanderso approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2024
@auto-submit auto-submit bot merged commit 3c0fd7c into flutter:main Sep 13, 2024
30 checks passed
@reidbaker reidbaker mentioned this pull request Sep 13, 2024
Open
@reidbaker
Copy link
Contributor Author

The license checker is probably skipping tests since they are not part of the shipped engine, however when we get around to improving the license checker it should check that all source files outside of third_party have the engine header.

Filed flutter/flutter#155163 to track licence checker work.

@reidbaker reidbaker deleted the i155118-copyright-notice-android-tests branch September 13, 2024 15:33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2024
@engine-flutter-autoroll
3c0fd7ca9 Add copyright notices to java test files (flutter/engine#55155
78abbaa 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2024
@engine-flutter-autoroll
3c0fd7ca9 Add copyright notices to java test files (flutter/engine#55155
0af76ac 
)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 13, 2024
@engine-flutter-autoroll
Roll Flutter Engine from bef48e87f438 to ab9daaa0bcc7 (3 revisions) (#…
07647ca 
…155172)

flutter/engine@bef48e8...ab9daaa

2024-09-13 [email protected] Roll Skia from 7cba76a07795 to a5a6d12b3642 (3 revisions) (flutter/engine#55179)
2024-09-13 [email protected] Add copyright notices to java test files (flutter/engine#55155)
2024-09-13 [email protected] Roll Skia from abb4eeac59c2 to 7cba76a07795 (1 revision) (flutter/engine#55174)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zanderso zanderso zanderso approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add copyright notice to android embedding tests.
3 participants
@reidbaker @yaakovschectman @zanderso