This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Rename viewId to viewIdentifier #52202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Apr 17, 2024
shell/platform/darwin/macos/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Headers/FlutterViewController.h
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Apr 17, 2024
loic-sharma
reviewed
Apr 17, 2024
shell/platform/darwin/macos/framework/Headers/FlutterViewController.h
Outdated
Show resolved
Hide resolved
dkwingsmt
changed the title
|
@cbracken @loic-sharma I should have addressed all comments. I removed |
cbracken
reviewed
Apr 18, 2024
shell/platform/darwin/macos/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
cbracken
reviewed
Apr 18, 2024
cbracken
reviewed
Apr 18, 2024
dkwingsmt
changed the title
cbracken
reviewed
Apr 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 19, 2024
…147022) flutter/engine@61bf47d...6e4a15d 2024-04-18 [email protected] [macOS] Rename viewId to viewIdentifier (flutter/engine#52202) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#147022) flutter/engine@61bf47d...6e4a15d 2024-04-18 [email protected] [macOS] Rename viewId to viewIdentifier (flutter/engine#52202) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
FlutterViewControllerwith new APIviewIdentifierand renames all occasions that mention "viewId" to "viewIdentifier", to align with the requirement for the iOS shell.A new typedef
FlutterViewIdentifieris also added.The problem is, we don't have a file to contain this typedef. Currently I put them in a new file calledIt has been moved tocommon.h. I'm open to other suggestions.FlutterViewController.h.int64_tdirectly. I'm ok with this choice too, since honestly it's just a 64 int.Also, macOS's definition for
kFlutterImplicitViewIdhas been removed in favor of the one incommon/constants.h.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.