Enable Metal validations for impeller_golden_tests

[zanderso]

No description provided.

[jonahwilliams]

We don't have to do this here, but unless there are issues I'm not aware of we should remove these flags. its too dangerous that we have a "by default don't test our impeller backends" setting.

[zanderso]

Do you mean: These flags are true by default, and disabled explicitly when building for release to omit the unneeded backends?

[zanderso]

I see two validation errors:

[ RUN      ] Play/AiksTest.CanDrawPoints/Vulkan
[ERROR:flutter/impeller/base/validation.cc(57)] Break on 'ImpellerValidationBreak' to inspect point of failure:
--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-VkWriteDescriptorSet-descriptorType-00328
|               ID Number: -368569266
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|                 Trigger: Validation Error: [ VUID-VkWriteDescriptorSet-descriptorType-00328 ] | MessageID = 0xea08144e | vkUpdateDescriptorSets(): pDescriptorWrites[1].pBufferInfo[0].offset (56) must be a multiple of device limit minStorageBufferOffsetAlignment 256 when descriptor type is VK_DESCRIPTOR_TYPE_STORAGE_BUFFER. The Vulkan spec states: If descriptorType is VK_DESCRIPTOR_TYPE_STORAGE_BUFFER or VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC, the offset member of each element of pBufferInfo must be a multiple of VkPhysicalDeviceLimits::minStorageBufferOffsetAlignment (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkWriteDescriptorSet-descriptorType-00328)
-----------------------------------------------------------------

And:

[ RUN      ] Play/AiksTest.CanDrawPointsWithTextureMap/Metal
validateComputeFunctionArguments:840: failed assertion `Compute Function(uv_compute_main): the offset into the buffer geometry_uv_data that is bound at buffer index 2 must be a multiple of 16 but was set to 16664.'

But it looks like the process ends after the first Metal validation error, so I guess there could be more after that.

[flutter-dashboard]

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

[jonahwilliams]

Thank you for the pointers on this one, I pulled these changes into #51341