Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@deniz-lee
Copy link

@deniz-lee deniz-lee commented Mar 4, 2024

Reverts the logic for calculating the TextField input text cursor position when inputting Korean characters (3.13.9)

  • Issue occurred since 3.16.x

List which issues are fixed by this PR. You must list at least one issue.

  • When entering Korean text, the input cursor must be located on the right side of the input text.
    However, when entering Korean text, the input cursor is located to the left of the entered character.

Recorded Video about the issue:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

…ition when inputting Korean characters (3.13.9)

- Issue occurred since 3.16.x
- flutter/flutter#140739
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Mar 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@deniz-lee deniz-lee closed this Mar 4, 2024
@deniz-lee deniz-lee deleted the text_cursor_position_incorrect_windows branch March 4, 2024 07:04
@deniz-lee
Copy link
Author

follow up on #51164

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant