Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

zanderso
Copy link
Member

No description provided.

@zanderso zanderso requested a review from keyonghan February 22, 2024 17:12
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 05ffcb1 into flutter:main Feb 22, 2024
@zanderso zanderso deleted the more-windows-rbe branch February 22, 2024 17:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 22, 2024
…143972)

flutter/engine@06448ee...cb6115d

2024-02-22 [email protected] Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 [email protected] Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 [email protected] Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 [email protected] Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 [email protected] Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 [email protected] Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 [email protected] [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 [email protected] Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 23, 2024
…sions) (#143989)

Manual roll requested by [email protected]

flutter/engine@06448ee...0f3ad23

2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement frame timing callbacks in Skwasm. (#50737)" (flutter/engine#50895)
2024-02-22 [email protected] Roll Dart SDK from 0f0f7400c38a to e2f2d9b464e9 (4 revisions) (flutter/engine#50881)
2024-02-22 [email protected] Roll Skia from a285cd79614c to 58772db6bc46 (3 revisions) (flutter/engine#50884)
2024-02-22 [email protected] [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880)
2024-02-22 [email protected] Build macOS engine as an xcframework (flutter/engine#50300)
2024-02-22 [email protected] Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878)
2024-02-22 [email protected] Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 [email protected] Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 [email protected] Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 [email protected] Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 [email protected] Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 [email protected] Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 [email protected] [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 [email protected] Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants