This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix macOS text composing #49314
Merged
Fix macOS text composing #49314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
force-pushed
the
fix-macos-text-composing
branch
from
6e8277f to
26afd05
Compare
LongCatIsLooong
force-pushed
the
fix-macos-text-composing
branch
from
26afd05 to
51b260f
Compare
LongCatIsLooong
commented
Dec 21, 2023
| cursor_pos += active_model_->composing_range().start(); | ||
| active_model_->UpdateComposingText(text); | ||
| active_model_->SetSelection(TextRange(cursor_pos, cursor_pos)); | ||
| active_model_->UpdateComposingText(text, TextRange(cursor_pos, cursor_pos)); |
Contributor
Author
There was a problem hiding this comment.
Not really related to this change, but isn't the composing text being added twice here?
Member
There was a problem hiding this comment.
You mean between AddText as well as UpdateComposingText? It sort of looks like it, though perhaps we're relying on a side effect of one or the other?
LongCatIsLooong
force-pushed
the
fix-macos-text-composing
branch
from
a1b4044 to
ecf8375
Compare
8 tasks
cbracken
approved these changes
Jan 9, 2024
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Overall looks great! Thanks for fixing this.
| cursor_pos += active_model_->composing_range().start(); | ||
| active_model_->UpdateComposingText(text); | ||
| active_model_->SetSelection(TextRange(cursor_pos, cursor_pos)); | ||
| active_model_->UpdateComposingText(text, TextRange(cursor_pos, cursor_pos)); |
Member
There was a problem hiding this comment.
You mean between AddText as well as UpdateComposingText? It sort of looks like it, though perhaps we're relying on a side effect of one or the other?
LongCatIsLooong
added
the
autosubmit
zijiehe-google-com
pushed a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 9, 2024
Fixes flutter/flutter#68547 (almost, this requires an oneliner framework patch to work). The selection wasn't being updated correctly before this so there were no highlights. Now the selection is properly highlighted (although it seems the styling has been updated in sonoma but it's better than offering no visual feedback): https://github.com/flutter/engine/assets/31859944/ab8557f4-7215-46de-8a9d-c2e3982695eb [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 10, 2024
…141217) flutter/engine@8c1501f...542fea9 2024-01-09 [email protected] Fix macOS text composing (flutter/engine#49314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2024
Fixes #68547 for macOS. Needs flutter/engine#49314
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#68547 (almost, this requires an oneliner framework patch to work).
The selection wasn't being updated correctly before this so there were no highlights. Now the selection is properly highlighted (although it seems the styling has been updated in sonoma but it's better than offering no visual feedback):
Screen.Recording.2023-12-21.at.12.00.38.AM.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.