This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix NSPrivacyCollectedDataTypes array in privacy manifest
#49041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
See test-exempt in #48951 (comment) |
|
test-exempt: apple does not provide a way to meaningfully test this |
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
…140176) flutter/engine@2140942...0e7248d 2023-12-14 [email protected] Fix a bug in the HTML render's `getClosestGlyphInfo` implementation (flutter/engine#48774) 2023-12-14 [email protected] Fix `NSPrivacyCollectedDataTypes` array in privacy manifest (flutter/engine#49041) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
wlx64133751
pushed a commit
to wlx64133751/engine
that referenced
this pull request
May 9, 2024
…49041) In flutter#48951 `NSPrivacyCollectedDataTypes` is an array with an empty dictionary, but the privacy report wants an empty array or it errors: <img width="523" alt="Screenshot 2023-12-14 at 10 02 52â�¯AM" src="https://github.com/flutter/flutter/assets/682784/a128b384-db2f-49d7-8b71-7965f2826de8"> When this is fixed the privacy report is blank, but that seems to be an Xcode bug? Will investigate. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style (cherry picked from commit 0ca2f38)
2ZeroSix
pushed a commit
to 2ZeroSix/engine
that referenced
this pull request
May 20, 2024
…49041) In flutter#48951 `NSPrivacyCollectedDataTypes` is an array with an empty dictionary, but the privacy report wants an empty array or it errors: <img width="523" alt="Screenshot 2023-12-14 at 10 02 52â�¯AM" src="https://github.com/flutter/flutter/assets/682784/a128b384-db2f-49d7-8b71-7965f2826de8"> When this is fixed the privacy report is blank, but that seems to be an Xcode bug? Will investigate. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #48951
NSPrivacyCollectedDataTypesis an array with an empty dictionary, but the privacy report wants an empty array or it errors:When this is fixed the privacy report is blank, but that seems to be an Xcode bug? Will investigate.
Fixes flutter/flutter#131494
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.