[Impeller] 🔥 Cast fireball on host-debug-impeller-vulkan and see what breaks.
#45999
Conversation
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
The readme updates seem valuable regardless of what this attempt at removing the variant reveals. If we do back it out, we should perhaps split this patch up?
|
I actually didn't intend to reformat the markdown, but agreed the changes are good. |
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/45999, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
|
auto label is removed for flutter/engine/45999, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
Converting back to a draft PR. I want to try something else. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
chinmaygarde
changed the title
host-debug-impeller-vulkan and see what breaks.host-debug-impeller-vulkan and see what breaks.
3 participants
Closes flutter/flutter#134675.
This is based off @chinmaygarde's suggestion in flutter/flutter#134675 (comment).
@bdero could you review as current engine on-duty? Thanks!