Reland "Use a single OffscreenCanvas for rendering in CanvasKit"

.ci.yaml

@@ -161,7 +161,6 @@ targets:
   - name: Linux Fuchsia
     recipe: engine/engine
     properties:
-      add_recipes_cq: "true"
       build_fuchsia: "true"
       fuchsia_ctl_version: version:0.0.27
       # ensure files from pre-production Fuchsia SDK tests are purged from cache
@@ -361,7 +360,7 @@ targets:
         {"download_emsdk": true}
       dependencies: >-
         [
-          {"dependency": "chrome_and_driver", "version": "version:115.0"},
+          {"dependency": "chrome_and_driver", "version": "version:119.0.6045.9"},
           {"dependency": "curl", "version": "version:7.64.0"}
         ]
       framework: "true"

.clang-tidy

@@ -1,8 +1,6 @@
 # A YAML format of https://clang.llvm.org/extra/clang-tidy/.
 
 # Prefix check with "-" to ignore.
-# Note: Some of the checks here are used as errors selectively, see
-# //ci/lint.sh
 Checks: >-
   bugprone-use-after-move,
   bugprone-unchecked-optional-access,
@@ -41,3 +39,11 @@ CheckOptions:
     value: "lower_case"
   - key: readability-identifier-naming.PrivateMemberSuffix
     value: "_"
+
+# Lint headers within paths that contain "/flutter/" but not:
+# - gen         (generated code, the fact it compiles is good enough™)
+# - third_party (we didn't author most of the code, and can't fix the lints)
+#
+# Note this is because of our buildroot setup, so the full path of a lint is:
+# "../../flutter/impeller/core/runtime_types.h:1:1" as reported.
+HeaderFilterRegex: "(!third_party/)(!gen/).*/flutter/.*"

.github/dependabot.yml

@@ -16,7 +16,7 @@ updates:
       - dependency-name: "github/codeql-action"
         update-types: ["version-update:semver-minor"]
   - package-ecosystem: "pub"
-    directory: "/lib/web_ui/pubspec.yaml"
+    directory: "/lib/web_ui"
     schedule:
       interval: "daily"
     labels:

.github/workflows/scorecards-analysis.yml

@@ -22,11 +22,11 @@ jobs:
       id-token: write
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
+        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
         with:
           persist-credentials: false
       - name: "Run analysis"
-        uses: ossf/scorecard-action@80e868c13c90f172d68d1f4501dee99e2479f7af
+        uses: ossf/scorecard-action@483ef80eb98fb506c348f7d62e28055e49fe2398
         with:
           results_file: results.sarif
           results_format: sarif

.github/workflows/third_party_scan.yml

@@ -25,11 +25,11 @@ jobs:
       id-token: write
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
+        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
         with:
           persist-credentials: false
       - name: "setup python"
-        uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1
+        uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236
         with:
           python-version: '3.7.7' # install the python version needed
       - name: "extract and flatten deps"

.gitignore

@@ -28,9 +28,6 @@ pubspec.lock
 docs/doxygen/
 xcuserdata
 
-third_party/gn/
-third_party/ninja/ninja*
-
 # Miscellaneous
 *.class
 *.lock
@@ -133,3 +130,4 @@ app.*.symbols
 
 # Prebuilt binaries.
 /prebuilts/
+/build/secondary/third_party/protobuf

analysis_options.yaml

@@ -7,6 +7,7 @@
 analyzer:
   language:
     strict-casts: true
+    strict-inference: true
     strict-raw-types: true
   errors:
     # allow self-reference to deprecated members (we do this because otherwise we have

build/bin_to_obj.gni

@@ -0,0 +1,103 @@
+# Copyright 2013 The Flutter Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Generates an assembly file defining a given symbol with the bytes from a
+# binary file. Places the symbol in a text section if 'executable' is true,
+# otherwise places the symbol in a read-only data section.
+template("bin_to_assembly") {
+  assert(defined(invoker.deps), "Must define deps")
+  assert(defined(invoker.input), "Must define input binary file")
+  assert(defined(invoker.symbol), "Must define symbol name")
+  assert(defined(invoker.executable), "Must define boolean executable")
+
+  action(target_name) {
+    deps = invoker.deps
+    script = "//third_party/dart/runtime/tools/bin_to_assembly.py"
+    output = "$target_gen_dir/${invoker.input}.S"
+    args = [
+      "--input",
+      rebase_path(invoker.input),
+      "--output",
+      rebase_path(output),
+      "--symbol_name",
+      invoker.symbol,
+      "--target_os",
+      current_os,
+    ]
+    if (defined(invoker.size_symbol)) {
+      args += [
+        "--size_symbol_name",
+        invoker.size_symbol,
+        "--target_arch",
+        current_cpu,
+      ]
+    }
+    if (invoker.executable) {
+      args += [ "--executable" ]
+    }
+    if (current_os != "win") {
+      args += [ "--incbin" ]
+    }
+    inputs = [
+      script,
+      invoker.input,
+    ]
+    outputs = [ output ]
+  }
+}
+
+# Generates an object file defining a given symbol with the bytes from a
+# binary file. Places the symbol in the read-only data section.
+template("bin_to_coff") {
+  assert(defined(invoker.deps), "Must define deps")
+  assert(defined(invoker.input), "Must define input binary file")
+  assert(defined(invoker.symbol), "Must define symbol name")
+  assert(defined(invoker.executable), "Must define executable")
+
+  action(target_name) {
+    deps = invoker.deps
+    script = "//third_party/dart/runtime/tools/bin_to_coff.py"
+    output = "$target_gen_dir/${invoker.input}.o"
+    args = [
+      "--input",
+      rebase_path(invoker.input),
+      "--output",
+      rebase_path(output),
+      "--symbol_name",
+      invoker.symbol,
+    ]
+
+    if (defined(invoker.size_symbol)) {
+      args += [
+        "--size_symbol_name",
+        invoker.size_symbol,
+      ]
+    }
+
+    if (invoker.executable) {
+      args += [ "--executable" ]
+    }
+
+    args += [ "--arch=$current_cpu" ]
+    inputs = [ invoker.input ]
+    outputs = [ output ]
+  }
+}
+
+# Generates a linkable output file defining the specified symbol with the bytes
+# from the binary file. Emits a COFF object file when targeting Windows,
+# otherwise assembly.
+template("bin_to_linkable") {
+  assert(defined(invoker.deps), "Must define deps")
+  assert(defined(invoker.input), "Must define input binary file")
+  assert(defined(invoker.symbol), "Must define symbol name")
+  target_type = "bin_to_assembly"
+  if (is_win) {
+    target_type = "bin_to_coff"
+  }
+
+  target(target_type, target_name) {
+    forward_variables_from(invoker, "*")
+  }
+}