[Impeller] Fix Vulkan validation error when there is a blit directed at a swapchain image. #43527
Conversation
…at a swapchain image.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I thought we were running unit-tests with validation enabled but that may not the case for test that toss open a playground window. And this one was in an advanced blend that had to be manually selected. |
| if (mode != StorageMode::kDeviceTransient) { | ||
| // TODO (https://github.com/flutter/flutter/issues/121634): | ||
| // Add transfer usage flags to support blit passes | ||
| // Add transfer usage flags to support blit passes only if image isn't |
There was a problem hiding this comment.
I found this outdated comment as I was looking for image usage flags. These flags are for allocated texture sources. The issue was with images that were wrapped swapchain images.
|
Does this fix flutter/flutter#129853 ? |
|
It fixes that exact issue yes. But this has thrown up another issue (a write-after-write hazard on the blit yielded by |
chinmaygarde
added
the
autosubmit
…irected at a swapchain image. (flutter/engine#43527)
…130296) flutter/engine@7d054ab...2a0dd9d 2023-07-10 [email protected] [Impeller] Fix Vulkan validation error when there is a blit directed at a swapchain image. (flutter/engine#43527) 2023-07-10 [email protected] Roll Skia from 89313a8cadab to aad8fbb17d69 (3 revisions) (flutter/engine#43526) 2023-07-10 [email protected] Roll Skia from c06d7ef5c276 to 89313a8cadab (2 revisions) (flutter/engine#43521) 2023-07-10 [email protected] [Impeller] Don't decompress into device buffer for Vulkan/GLES. (flutter/engine#43493) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…at a swapchain image. (flutter#43527) This shows up in the the aiks test harness in the color wheel with advanced blends. Fixes flutter/flutter#129853
…0296) flutter/engine@7d054ab...2a0dd9d 2023-07-10 [email protected] [Impeller] Fix Vulkan validation error when there is a blit directed at a swapchain image. (flutter/engine#43527) 2023-07-10 [email protected] Roll Skia from 89313a8cadab to aad8fbb17d69 (3 revisions) (flutter/engine#43526) 2023-07-10 [email protected] Roll Skia from c06d7ef5c276 to 89313a8cadab (2 revisions) (flutter/engine#43521) 2023-07-10 [email protected] [Impeller] Don't decompress into device buffer for Vulkan/GLES. (flutter/engine#43493) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This shows up in the the aiks test harness in the color wheel with advanced blends.
Fixes flutter/flutter#129853