Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend #43094

Merged
bdero merged 2 commits into from
Jun 22, 2023
Merged

[Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend #43094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5983f5d
[Impeller] Add validation forbidding SamplerAddressMode::kDecal on th…
bdero Jun 22, 2023
3682cda
Link to issue
bdero Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions impeller/renderer/backend/gles/context_gles.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ ContextGLES::ContextGLES(std::unique_ptr<ProcTableGLES> gl,
.SetSupportsComputeSubgroups(false)
.SetSupportsReadFromResolve(false)
.SetSupportsReadFromOnscreenTexture(false)
.SetSupportsDecalTileMode(false)
.Build();
}

Expand Down
13 changes: 13 additions & 0 deletions impeller/renderer/backend/gles/sampler_library_gles.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#include "impeller/renderer/backend/gles/sampler_library_gles.h"

#include "impeller/base/config.h"
#include "impeller/base/validation.h"
#include "impeller/core/formats.h"
#include "impeller/renderer/backend/gles/sampler_gles.h"

namespace impeller {
Expand All @@ -17,6 +19,17 @@ SamplerLibraryGLES::~SamplerLibraryGLES() = default;
// |SamplerLibrary|
std::shared_ptr<const Sampler> SamplerLibraryGLES::GetSampler(
SamplerDescriptor descriptor) {
// TODO(bdero): Change this validation once optional support for kDecal is
// added to the OpenGLES backend:
// https://github.com/flutter/flutter/issues/129358
if (descriptor.width_address_mode == SamplerAddressMode::kDecal ||
descriptor.height_address_mode == SamplerAddressMode::kDecal ||
descriptor.depth_address_mode == SamplerAddressMode::kDecal) {
VALIDATION_LOG << "SamplerAddressMode::kDecal is not supported by the "
Copy link
Member

@zanderso zanderso Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A TODO linking to a GItHub issue would probably be helpful here.

Copy link
Member Author

@bdero bdero Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done & filed this issue: flutter/flutter#129358

"OpenGLES backend.";
return nullptr;
}

auto found = samplers_.find(descriptor);
if (found != samplers_.end()) {
return found->second;
Expand Down