This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] [Impeller] Ignore the Z basis when scaling text (#41995) #42053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter/flutter#126510. `GetMaxBasisLength()` includes the Z basis vector, which happens to not be getting scaled down along with the X and Y for this reproduction case. And so given the 2D nature of text and the intent of this scale parameter, it's returning a value that's too large here. (cherry picked from commit 6dc9b28)
zanderso
approved these changes
May 15, 2023
Contributor
|
rerunning linux android aot since it looks like a flake |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP of #41995.