Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use release_build and os dimension consistently. #42012

Merged
auto-submit merged 5 commits into from
May 15, 2023
Merged

Use release_build and os dimension consistently. #42012

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54f4323
Use release_build and os dimension consistently.
godofredoc May 13, 2023
f70ef37
Move to drone_dimensions.
godofredoc May 15, 2023
0c704e1
Move to drone dimensions.
godofredoc May 15, 2023
49a94c5
Move drone_dimensions to properties.
godofredoc May 15, 2023
063cbe6
Add version to os dimension.
godofredoc May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,17 +262,23 @@ targets:
properties:
release_build: "true"
config_name: linux_fuchsia
drone_dimensions: >
["os=Linux"]

- name: Linux linux_arm_host_engine
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
config_name: linux_arm_host_engine
drone_dimensions: >
["os=Linux"]

- name: Linux linux_host_engine
recipe: engine_v2/engine_v2
timeout: 60
dimensions:
os: "Linux"
properties:
release_build: "true"
config_name: linux_host_engine
Expand All @@ -283,26 +289,31 @@ targets:
properties:
release_build: "true"
config_name: linux_host_desktop_engine
drone_dimensions: >
["os=Linux"]

- name: Linux linux_android_aot_engine
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
config_name: linux_android_aot_engine
drone_dimensions: >
["os=Linux"]

- name: Linux linux_android_debug_engine
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
config_name: linux_android_debug_engine
drone_dimensions: >
["os=Linux"]

- name: Linux linux_license
recipe: engine_v2/builder
timeout: 60
properties:
release_build: "true"
config_name: linux_license
clobber: "true"

Expand All @@ -312,12 +323,13 @@ targets:
properties:
release_build: "true"
config_name: linux_web_engine
drone_dimensions: >
["os=Linux"]

- name: Linux linux_unopt
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
config_name: linux_unopt

- name: Linux Web Framework tests
Expand Down Expand Up @@ -375,7 +387,10 @@ targets:
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
config_name: mac_android_aot_engine
drone_dimensions: >
["os=Linux"]

- name: Mac mac_clang_tidy
recipe: engine_v2/engine_v2
Expand Down Expand Up @@ -409,6 +424,8 @@ targets:
]
$flutter/osx_sdk : >-
{ "sdk_version": "14e222b" }
drone_dimensions: >
["os=Mac-12"]

- name: Linux mac_unopt
recipe: engine_v2/engine_v2
Expand Down Expand Up @@ -494,13 +511,14 @@ targets:
[
{"dependency": "jazzy", "version": "0.14.1"}
]
drone_dimensions: >
["os=Mac-12"]

- name: Mac impeller-cmake-example
bringup: true
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
Copy link
Contributor

@keyonghan keyonghan May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the PR description:

Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal.

I didn't quite follow why we need to remove here. Do we not want to run them against dart_internal any more?

Copy link
Contributor Author

@godofredoc godofredoc May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only builders generating artifacts will be running in dart-internal. Builders like "Mac impeller-cmake-example" are test only and should not run in dart-internal.

cpu: arm64
config_name: mac_impeller_cmake_example

Expand Down Expand Up @@ -529,13 +547,17 @@ targets:
properties:
release_build: "true"
config_name: windows_android_aot_engine
drone_dimensions: >
["os=Windows"]

- name: Windows windows_host_engine
recipe: engine_v2/engine_v2
timeout: 60
properties:
release_build: "true"
config_name: windows_host_engine
drone_dimensions: >
["os=Windows"]

- name: Windows windows_arm_host_engine
recipe: engine_v2/engine_v2
Expand All @@ -546,6 +568,8 @@ targets:
properties:
release_build: "true"
config_name: windows_arm_host_engine
drone_dimensions: >
["os=Windows"]

- name: Windows windows_unopt
recipe: engine_v2/builder
Expand Down