This repository was archived by the owner on Feb 25, 2025. It is now read-only.
CP: Update infrastructure python code to be compatible with python 2 and … #39443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…python 3 (#39133) * Compatibility with python2 and python3 * Formatting * Updated to use a function instead of decoding bytes in multiple places. * Formatting and whitespace cleanup. * Fix import statement. * Linter change for docstring. * Formatting. * Remove function from run_tests.py since it is a pain to import. * Add todo message for python 2 deprecation. * Updated copyright year.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
fluttergithubbot
approved these changes
Feb 7, 2023
XilaiZhang
approved these changes
Feb 7, 2023
* Migrate engine_v2_builds to python3. Python2 has already been deprecated and the the python binary removed from path. * Also use python3 for global generators.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP: ba188d7
CP: aa0ff21
CP: 9cc2a8e
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.