This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Apparently we only need to call this function on Android #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No clue how to review this. @chinmaygarde @jamesr |
Contributor
|
If you aren't using the ui/gl/ provided GL binding functions, why do you need to call this anywhere? |
Contributor
Author
|
I just created this patch because @chinmaygarde told me too. Maybe @chinmaygarde can answer your question... |
bungeman
pushed a commit
to bungeman/engine
that referenced
this pull request
Nov 16, 2020
Newer GN doesn't allow `*.framework` elements in `libs`. It requires using `frameworks` instead. The toolchain definitions need to pass the new substituted variable to the link to make use of the new required way to express these dependencies. This was a change made in the Dart repo here https://dart-review.googlesource.com/c/sdk/+/155482 and in order to get roll this newer version of Dart this change is needed.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* [WIP] Add angular_test based tests to web-angular-simple Fixes flutter#386 * Update to angular2 3.0.0-beta+1 * update ACX and NG vers in web-angular-* * update SDK to 1.23.0 for web-angular-* * validate_templates: allow SDK 1.23.0 for angular templates * Update pubspec and changelog version to 1.1.1-dev, 1.1.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.