This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller Scene] Command encoding #37977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdero
commented
Nov 30, 2022
bdero
commented
- Render pass.
- Resolve pipelines
- Encode commands.
- Placeholder texture with lifetime of the scene.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Nov 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 30, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 30, 2022
…116290) * 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973) * 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974) * 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977) * 13f136efb [deps] Add `package:intl` (flutter/engine#37980) * 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (#37973)" (flutter/engine#37982)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…lutter#116290) * 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973) * 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974) * 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977) * 13f136efb [deps] Add `package:intl` (flutter/engine#37980) * 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116290) * 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973) * 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974) * 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977) * 13f136efb [deps] Add `package:intl` (flutter/engine#37980) * 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116290) * 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973) * 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974) * 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977) * 13f136efb [deps] Add `package:intl` (flutter/engine#37980) * 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.