This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added integration test for platform channels on windows. #36853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
windows_integration_test_platform_channls
branch
2 times, most recently
from
9424fcc to
6d4bf1f
Compare
gaaclarke
force-pushed
the
windows_integration_test_platform_channls
branch
from
6d4bf1f to
fd82337
Compare
gaaclarke
force-pushed
the
windows_integration_test_platform_channls
branch
from
fd82337 to
2c5c73b
Compare
loic-sharma
reviewed
Oct 20, 2022
| ui.PlatformDispatcher.instance.sendPlatformMessage('hi', data, | ||
| (ByteData? reply) { | ||
| ui.PlatformDispatcher.instance | ||
| .sendPlatformMessage('hi', reply, (ByteData? reply) {}); |
Member
There was a problem hiding this comment.
Is this supposed to be bye instead of hi? The test seems to be checking for a message starting with b too.
Member
Author
There was a problem hiding this comment.
Yea, it's a bit confusing. I'm not sure how to make it more clear, "hi" is the name of the channel, not the payload. Dart just echos the payloads that it gets from the c++ side.
loic-sharma
reviewed
Oct 20, 2022
| } // namespace | ||
|
|
||
| TEST(FlutterWindowsEngine, RunDoesExpectedInitialization) { | ||
| class FlutterWindowsEngineTest : public WindowsTest {}; |
Member
There was a problem hiding this comment.
Just curious for my own knowledge, what are the benefits of this?
Member
Author
There was a problem hiding this comment.
The WindowsTest class has access to the dart code that is compiled into the test runner. This tripped me up for a long time but you can't send and receive messages on windows unless you have a running engine, and you can't have a running engine without a dart kernel to execute. (On iOS and Android that isn't the case.) That's why I had to make this test suit a subclass of WindowsTest.
loic-sharma
approved these changes
Oct 20, 2022
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
LGTM but left some questions
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 21, 2022
* e27e196 Add touch-input-test to test_suites.yaml (flutter/engine#36900) * b923707 [Impeller] remove solid stroke contents and allow strokes/vertices to use color sources (flutter/engine#36896) * 85e4fa8 Roll Dart SDK from e06db8e1b620 to 1d418b40d8bd (1 revision) (flutter/engine#36902) * 0b57b1c Roll buildroot to a680bb1. (flutter/engine#36901) * f1634aa Roll Fuchsia Mac SDK from IdQEnRNQNY7ZrLZ04... to jB4jUAxe89I2A-yqv... (flutter/engine#36904) * f24ea1a Roll Fuchsia Linux SDK from g6-kU8so3PDiR1106... to mdl-0MUwR6uuQdKIm... (flutter/engine#36905) * 04fa86e Added integration test for platform channels on windows. (flutter/engine#36853) * 1dbf3ff Convert the executable directory path to UTF-8 on Windows (flutter/engine#36908) * c3d4fc9 Roll Dart SDK from 1d418b40d8bd to f1d4c7c808bd (2 revisions) (flutter/engine#36913) * 51b66c9 [Web] Synthesize key events for shift key on pointer events. (flutter/engine#36724) * 584fffb Roll Fuchsia Mac SDK from jB4jUAxe89I2A-yqv... to fcFu9Z2KJH6oQvHnG... (flutter/engine#36919) * 4369421 Roll Fuchsia Linux SDK from mdl-0MUwR6uuQdKIm... to NqPnoRHl3WYqH3SrC... (flutter/engine#36920) * d6d38ab [Impeller] fix null geometry (flutter/engine#36922) * d7f987e [Impeller] Eliminate unused shader output (flutter/engine#36923) * c255470 Roll Dart SDK from f1d4c7c808bd to eafe0119c9f5 (2 revisions) (flutter/engine#36925) * 224a3de Restore support for building the web SDK without a prebuilt Dart SDK (flutter/engine#36926) * c7c21e5 Re-landing Robolectric 4.8.1 (flutter/engine#34272) * ab98023 Roll libtess2 to 725e5e08ec8751477565f1d603fd7eb9058c277c (flutter/engine#36928) * 95e937a Revert "Roll libtess2 to 725e5e08ec8751477565f1d603fd7eb9058c277c (#36928)" (flutter/engine#36932) * 83092c0 Revert Dart SDK to 2.19.0-324.0.dev (flutter/engine#36930)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integration test for windows platform channels. This is preliminary groundwork to implementing background platform channels for windows.
issue: flutter/flutter#91635
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.