Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Oct 17, 2022

Reverts #36520

@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Oct 17, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2022

This pull request cannot be merged due to conflicts. Please resolve conflicts and re-add the revert label.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2022

A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id'

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
@eyebrowsoffire eyebrowsoffire added the revert Label used to revert changes in a closed and merged pull request. label Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-web Code specifically for the web engine revert Label used to revert changes in a closed and merged pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants