This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for assertive announcements in aria-live #34640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
8 tasks
yjbanov
approved these changes
Jul 20, 2022
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
Only a few nitpicks in this PR. This overall LGTM modulo the ariaLivePolitenessSetting name in the protocol, which sounds too much web-specific. I think we should keep the framework-side as cross-platform as possible.
nbayati
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 23, 2022
Merged
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for two different modes of aria announcements: polite/assertive via setting the
aria-liveflag.This PR makes the default to be
assertiveand provides an optional flag to set the mode topoliteFixes flutter/flutter#104109
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.